Prevent Commander list scrambling on save-load #3403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents the list of commanders in the command tab from being jumbled up when loading a save by sorting the list by droid ID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the list of commanders in the command tab from being jumbled up when loading a save by sorting the list by droid ID.
Currently, save-loading the game causes the order of the commanders in the commander menu to be changed, which can be seen here (screenshots taken in master build):
Before save-load:
After save-load:
Notice how the order of the commanders in the menu have been reversed.
With this PR, the commander menu order is preserved on save-load.
Before save-load:
After save-load: