Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies issue #11

Open
andrewwood-wbg opened this issue Mar 23, 2021 · 2 comments · Fixed by #12
Open

Dependencies issue #11

andrewwood-wbg opened this issue Mar 23, 2021 · 2 comments · Fixed by #12

Comments

@andrewwood-wbg
Copy link

andrewwood-wbg commented Mar 23, 2021

Default install of Python 3.9.2 gives you ctap-keyring-device 1.0.6 which satisfies requirements.txt checks, however that requires fido2>=0.9.1 which fails the requirements.txt check.

Release notes for fido https://github.com/Yubico/python-fido2/releases suggest nothing that would break so maybe we can just update the version in the requirements.txt?

@delilahlah
Copy link
Contributor

I'm seeing the same thing with with a fresh install.

This fixed it for me:

diff --git a/requirements.txt b/requirements.txt
index 9ac6d46..cc6731b 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -4,6 +4,6 @@ beautifulsoup4>=4.6.0,<5.0.0
 configparser>=3.5.0,<4.0.0
 keyring>=21.4.0
 requests>=2.13.0,<3.0.0
-fido2>=0.8.1,<=0.9.0
+fido2>=0.9.1
 okta>=0.0.4,<1.0.0
 ctap-keyring-device>=1.0.4

@chjones chjones linked a pull request Apr 19, 2021 that will close this issue
9 tasks
@chjones
Copy link
Collaborator

chjones commented Apr 19, 2021

I linked #12, I believe this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants