Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats test cases #1

Open
Walnut356 opened this issue Apr 27, 2023 · 0 comments
Open

Stats test cases #1

Walnut356 opened this issue Apr 27, 2023 · 0 comments

Comments

@Walnut356
Copy link
Owner

I was hesitant to make these while I was changing the stats fields so often. Now that they're changing less often, it's probably a good idea to make some tests for the following:

  • Each stat processes all the way through without errors
  • get_stats can process several replays without getting stuck
  • Each stat output matches a pre-verified output. The easiest way to go about this is making a 10 second or so replay vs a CPU with a few instances of the event. To save work in the future, it might be worth only comparing the number of rows, or rows + some columns that aren't going anywhere, since otherwise it will fail and need updating if a new column is ever added.

I also wouldn't mind some more replays of older slippi versions, but I can probably just grab those from slippi.gg's tournament sets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant