Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL bar control does not appear for some supported content #1

Open
WPettersson opened this issue Jun 24, 2019 · 2 comments
Open

URL bar control does not appear for some supported content #1

WPettersson opened this issue Jun 24, 2019 · 2 comments

Comments

@WPettersson
Copy link
Owner

(This came in via email, as I had issues disabled. Reposting for posterity.)

Send to Kodi 2 is apparently the only Kodi-push extension in the Firefox catalogue that works on Firefox Android, because it places the media push control in the URL bar. However, the URL bar icon does not appear in every case where it
encounters a supported format, for example this free podcasting site:

http://www.blogtalkradio.com/

If you view source for any users podcast page on this site, you can see there is only one embedded MP3 media link for each podcast - and it's not obfuscated. Also, many radio & TV stations have a free live stream, and the stream link is
typically the only media link on the page. Stuff like this should be detectable without site specific support.

Also note the issue tracker on Github is disabled.

@WPettersson
Copy link
Owner Author

The main issue with detecting all pages that contain exactly one media element is that currently the URL bar control is added based only on the URL of the page being loaded, which is relatively light-weight. I'm not that much of an expert on the API for Firefox addons, but if I want to detect pages with one media element, I'd now need to subscribe to events that update the DOM, and on each update, search for media tags. The search itself is trivial to code, but I'm wary of the number of times such a search would have to be called - a limit too low might not detect a media tag that appears later, but a limit too high could adversely affect performance.

One initial option is to specifically "white-list" the generic URL you mention, but as you point out there are many other sites that it should probably match, leaving this as also an undesirable option.

I'll keep thinking on this, but I wanted to let you know my current thoughts.

@kekukui
Copy link

kekukui commented Jun 27, 2019

I found an extension which basically supports this, but the feature is undocumented. My initial impression of how it works is that media links would be detected automatically on sites which are explicitly supported by the extension (and/or by Kodi apps with a dedicated scraper designed for that site). For most other sites, you would have to click on the media link as if you were going to play or download the content before the URL will be added to the list of media links which can be pushed to Kodi -- so this capability would not be obvious, unless you noticed that the link counter on the menu bar had been incremented as a result of your interaction with the page.

https://addons.mozilla.org/en-US/firefox/addon/kodi-control
https://github.com/LendoK/kodi-control

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants