Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreadable dark text on dark background in pkgdown navbar #4

Closed
jadeynryan opened this issue Jan 30, 2024 · 5 comments
Closed

Unreadable dark text on dark background in pkgdown navbar #4

jadeynryan opened this issue Jan 30, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@jadeynryan
Copy link
Contributor

Known issue. Setting type: light or type:dark does not help. Will have to wait until pkgdown has fixed r-lib/pkgdown#2387. Tan submitted a PR fix r-lib/pkgdown#2388.

@jadeynryan jadeynryan added the bug Something isn't working label Jan 30, 2024
@tanho63
Copy link

tanho63 commented Feb 8, 2024

popping by to say this got merged into pkgdown-main 😀

@jadeynryan
Copy link
Contributor Author

Thanks @tanho63! I updated {pkgdown} to the dev version, rebuilt the site, and then redeployed. But the navbar text is still black. Do you have any suggestions?

@jadeynryan
Copy link
Contributor Author

I think it's because the GitHub Action isn't using the dev version of {pkgdown}... but I'm not sure how to specify that in the pkgdown.yaml workflow file.

@tanho63
Copy link

tanho63 commented Feb 16, 2024

Two things to change: instead of any::pkgdown you should use r-lib/pkgdown, and add type: dark under navbar in your pkgdown.yml https://pkgdown.r-lib.org/articles/customise.html#navbar-style

@jadeynryan
Copy link
Contributor Author

Thank you SO much! You're the best. ☺

jadeynryan added a commit that referenced this issue Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants