Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of multi_pin aliases #85

Open
HumbleDeer opened this issue Sep 27, 2023 · 4 comments
Open

Make use of multi_pin aliases #85

HumbleDeer opened this issue Sep 27, 2023 · 4 comments
Assignees
Labels
🔧 Configuration Raspberry Pi, Klipper, Mainsail, Moonraker ⚡Electronics Electronics, electrical wiring, PCB's Vz235 Mellow VzBoT-235 Mellow kit Vz330 Mellow VzBoT-330 Mellow kit

Comments

@HumbleDeer
Copy link

HumbleDeer commented Sep 27, 2023

Proposal: use [multi_pin xxx] in config files

Make use of some multi_pin aliases and/or controller_fan definitions to control fans otherwise controlled by different pins.

There's multiple parts of the printer where multiple accessories are controlled as one device. For example:

  • RSCS: 2 fans
  • Exhaust Vz235: 2 fans
  • Controller / driver fans: optional but multiple

Not fans, but also possible to control in groups (provided pins are set up correctly):

  • LED's: Multiple types possible
  • Bed SSR: Some people use two SSR's for full protection on both the Line and Neutral lines (in countries with no or different standard polarity on plugs despite grounding)

Aux fans / RSCS fans

Reference:
https://www.klipper3d.org/Config_Reference.html#multi_pin

Example:

[multi_pin rscs_fans]
pins: pin1, pin2

[fan rscs_fan]
pin: multi_pin:rscs_fans

Exhaust fans

Vz235 has two smaller exhaust fans instead of the Vz330's single larger fan. These can be combined using a multi_pin alias as well.

[multi_pin exhaust_fans]
pins: pin1, pin2

[fan exhaust_fan]
pin: multi_pin:exhaust_fans

Stepper driver fans

Configuring the stepper driver fans to be driven by four fan ports on the motherboard

Reference:
https://www.klipper3d.org/Config_Reference.html#multi_pin
https://www.klipper3d.org/Config_Reference.html#controller_fan

[multi_pin controller_fans]
pins: PA2, PA3

[controller_fan controller_fan]
pin: multi_pin:controller_fans
kick_start_time: 0.5
#fan_speed: 0.5
stepper:
#   Name of the config section defining the stepper that this fan is
#   associated with. A **comma separated list** of stepper names will 
#   enable the fan when any of them are enabled. 
#   **The default stepper is all of them.**

Partially courtesy of @AxMod3DPrint

@HumbleDeer HumbleDeer self-assigned this Sep 27, 2023
@HumbleDeer HumbleDeer added Vz330 Mellow VzBoT-330 Mellow kit Vz235 Mellow VzBoT-235 Mellow kit ⚡Electronics Electronics, electrical wiring, PCB's 🔧 Configuration Raspberry Pi, Klipper, Mainsail, Moonraker labels Sep 27, 2023
@HumbleDeer HumbleDeer assigned pbsuper and unassigned HumbleDeer Oct 2, 2023
@tehmaze
Copy link
Member

tehmaze commented Oct 11, 2023

Great idea overall and allows for a more clutter-free RCSC setup for example.

Let's leave out the pin setup for the driver fans, as they are supposed to be connected to the stepper driver directly in a typical setup; however we can of course provide a commented-out example plus documentation in the printer.cfg we provide.

@HumbleDeer
Copy link
Author

HumbleDeer commented Oct 11, 2023

This could tie in nicely with some suggestions as well as ideas I took over from the guys over at mellow-3d.github.io.

The way they have their config files modular for each motherboard is not only a great idea, but a fantastic resource right out of the gate. This would solve issues like the one Nero had, where he had to redo his whole config cause the pin diagram we provide is a different board type than the one he got.

I agree with Nero that we should be supplying config files for all possible configurations that the Mellow kit could come in. The modular way of working would really help with editing the configs on the user side of things as well.

See this: https://mellow-3d.github.io/fly_super8_klipper_mcu_config.html#fly-super8-aliases-file

@tehmaze
Copy link
Member

tehmaze commented Oct 11, 2023

That's nice if you're a vendor with a limited set of boards that are fully under your control, but it gets out of hand fast if we have to support printers * boards pin aliases and matching configurations. That isn't to say we can't provide a set of pin alias stubs plus reference configuration files for the most popular boards out there, thinking of:

  • Mellow Fly Super8 Pro
  • Fysetc Spider v2.x
  • BTT Octopus (Pro)

@HumbleDeer
Copy link
Author

I'm not suggesting we support all boards. I suggest we support the three versions of Mellow board we talk about in the docs. Those are the ones that make sense, as they're the ones the kits and BOM have.

It would also make sense to actually rename the printer configs printer-vz235awd.cfg for example, or other verbose and descriptive terms in both the titles and the file inside.

But @pbsuper told me to keep mn fikken van de printer configs :')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 Configuration Raspberry Pi, Klipper, Mainsail, Moonraker ⚡Electronics Electronics, electrical wiring, PCB's Vz235 Mellow VzBoT-235 Mellow kit Vz330 Mellow VzBoT-330 Mellow kit
Projects
None yet
Development

No branches or pull requests

3 participants