Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

null as a string is appearing in various places #1166

Open
Tracked by #1164
andymeneely opened this issue Oct 25, 2023 · 1 comment · May be fixed by #1184
Open
Tracked by #1164

null as a string is appearing in various places #1166

andymeneely opened this issue Oct 25, 2023 · 1 comment · May be fixed by #1184
Assignees
Labels

Comments

@andymeneely
Copy link
Collaborator

andymeneely commented Oct 25, 2023

For example, when I create a new curation, the nickname defaults to null

There may be more than one cause of this. I did some janky stopgap fixes (e.g. upvotes), but I didn't fix them all. I think there's got to be a JSON.stringify issue happening here or something. Instead of null these should be empty fields. For example, the value of description defaults to the string null when it should be an empty string.

@andymeneely andymeneely changed the title null as a string is appearing in various places. There may be more than one cause of this, and I have some stopgap fixes in place, but I didn't fix them all. I think there's got to be a JSON.stringify issue happening here or something. Instead of null these should be empty fields. For example, nickname defaults to null when it should be an empty string. null as a string is appearing in various places Oct 25, 2023
@brianravi
Copy link
Contributor

added a function to recursively loop through the object and set nulls to "". put in special case for upvotes to be 0.

@brianravi brianravi linked a pull request Oct 27, 2023 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 📋 TODO
Development

Successfully merging a pull request may close this issue.

2 participants