Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Numbers and Conversion clients to use DynamicEndpoint #477

Merged
merged 5 commits into from
Aug 29, 2023
Merged

Conversation

SMadani
Copy link
Contributor

@SMadani SMadani commented Aug 28, 2023

This continues the work of moving to a more declarative way of implementing and testing endpoints by decoupling from Apache HttpClient. This PR targets the Numbers and Conversion APIs.

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2023

Codecov Report

Merging #477 (f2abb49) into main (5ee1f52) will decrease coverage by 0.02%.
The diff coverage is 91.86%.

@@             Coverage Diff              @@
##               main     #477      +/-   ##
============================================
- Coverage     93.55%   93.53%   -0.02%     
+ Complexity     2884     2855      -29     
============================================
  Files           443      439       -4     
  Lines          7294     7243      -51     
  Branches        440      443       +3     
============================================
- Hits           6824     6775      -49     
+ Misses          279      275       -4     
- Partials        191      193       +2     
Files Changed Coverage Δ
...a/com/vonage/client/numbers/ListNumbersFilter.java 93.75% <77.77%> (-6.25%) ⬇️
...com/vonage/client/numbers/SearchNumbersFilter.java 92.30% <81.81%> (-4.92%) ⬇️
...a/com/vonage/client/numbers/BaseNumberRequest.java 83.33% <83.33%> (ø)
...onage/client/numbers/NumbersResponseException.java 87.50% <87.50%> (ø)
...com/vonage/client/conversion/ConversionClient.java 100.00% <100.00%> (ø)
...om/vonage/client/conversion/ConversionRequest.java 100.00% <100.00%> (ø)
...va/com/vonage/client/numbers/BuyNumberRequest.java 100.00% <100.00%> (ø)
...com/vonage/client/numbers/CancelNumberRequest.java 100.00% <100.00%> (ø)
...com/vonage/client/numbers/ListNumbersResponse.java 100.00% <100.00%> (ø)
.../java/com/vonage/client/numbers/NumbersClient.java 100.00% <100.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

@SMadani SMadani marked this pull request as ready for review August 29, 2023 15:38
Copy link

@maxkahan maxkahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it, I'll take 100

@SMadani SMadani merged commit ff72718 into main Aug 29, 2023
11 checks passed
@SMadani SMadani deleted the numbers branch August 29, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants