Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Users API #468

Merged
merged 15 commits into from
Aug 10, 2023
Merged

Add Users API #468

merged 15 commits into from
Aug 10, 2023

Conversation

SMadani
Copy link
Contributor

@SMadani SMadani commented Aug 2, 2023

Implementation of Users API.

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Merging #468 (b6bbda0) into main (16fd480) will decrease coverage by 0.30%.
The diff coverage is 85.51%.

@@             Coverage Diff              @@
##               main     #468      +/-   ##
============================================
- Coverage     93.84%   93.55%   -0.30%     
- Complexity     2755     2884     +129     
============================================
  Files           425      443      +18     
  Lines          7006     7294     +288     
  Branches        389      440      +51     
============================================
+ Hits           6575     6824     +249     
+ Misses          280      279       -1     
- Partials        151      191      +40     
Files Changed Coverage Δ
...ava/com/vonage/client/users/ListUsersResponse.java 66.66% <66.66%> (ø)
...rc/main/java/com/vonage/client/users/BaseUser.java 72.72% <72.72%> (ø)
...ain/java/com/vonage/client/users/channels/Sip.java 72.72% <72.72%> (ø)
...ava/com/vonage/client/users/channels/Channels.java 72.91% <72.91%> (ø)
...va/com/vonage/client/users/channels/Messenger.java 80.00% <80.00%> (ø)
...om/vonage/client/users/channels/NumberChannel.java 80.00% <80.00%> (ø)
...ain/java/com/vonage/client/users/channels/Vbc.java 80.00% <80.00%> (ø)
src/main/java/com/vonage/client/users/User.java 83.72% <83.72%> (ø)
...va/com/vonage/client/users/channels/Websocket.java 84.37% <84.37%> (ø)
...java/com/vonage/client/users/ListUsersRequest.java 97.50% <97.50%> (ø)
... and 11 more

... and 1 file with indirect coverage changes

@SMadani SMadani marked this pull request as ready for review August 9, 2023 16:45
Copy link

@manchuck manchuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@SMadani SMadani merged commit d9d801c into main Aug 10, 2023
10 of 11 checks passed
@SMadani SMadani deleted the users branch August 10, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants