Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of return codes than assert #265

Closed
pranjalchanda08 opened this issue Dec 24, 2023 · 1 comment · Fixed by #266 or #272
Closed

Use of return codes than assert #265

pranjalchanda08 opened this issue Dec 24, 2023 · 1 comment · Fixed by #266 or #272
Assignees
@akashkollipara
Labels
cyancore framework Cyancore framework feature request

Comments

@pranjalchanda08
Copy link
Contributor

Describe the bug
In many cases the driver automatically panics and does not let the user act upon the error cases in a dynamic environment.
It is better to:

  • Use return codes instead of asserts and let the user decide what to perform with the returned code.
  • Use positive error codes to accommodate 0x0000 to 0xffff error codes.
@pranjalchanda08 pranjalchanda08 added the cyancore framework Cyancore framework feature request label Dec 24, 2023
akashkollipara added a commit that referenced this issue Dec 24, 2023
@akashkollipara
<Status> Updated status codes to use +ve values.
0cc5bd9 
- Using +ve values, will increase the range to 0-65535 for 16b enums

Issue: #265
akashkollipara added a commit that referenced this issue Dec 24, 2023
@akashkollipara
<Err> Updated error handling
7813dc1 
- Added new status code

Issue: #265
@akashkollipara akashkollipara linked a pull request Jan 3, 2024 that will close this issue
Bugfix/akashkollipara/status codes #266
Merged
akashkollipara added a commit that referenced this issue Jan 3, 2024
@akashkollipara
Additional fixes and cosmetic updates for status codes
ce87773 
Issue: #265
@akashkollipara
Copy link
Member

Closing this issue...

akashkollipara added a commit that referenced this issue Jan 3, 2024
@akashkollipara
<SiFive> Fixed error handling in platform timer
c42e1c4 
- Minor bugfix in status check coreid

Issue: #237 #265
akashkollipara added a commit that referenced this issue Jan 3, 2024
@akashkollipara
<SiFive> Fixed error handling in platform timer
c33f791 
- Minor bugfix in status check coreid

Issue: #237 #265
akashkollipara added a commit that referenced this issue Jan 3, 2024
@akashkollipara
<Mega AVR> Updated status code on HAL
23db466 
Issue: #265
@akashkollipara akashkollipara linked a pull request Jan 3, 2024 that will close this issue
Development #272
Merged
@akashkollipara akashkollipara moved this to Done in Terravisor Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akashkollipara akashkollipara

Labels
cyancore framework Cyancore framework feature request
Projects
Terravisor
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix/akashkollipara/status codes VisorFolks/cyancore
Development VisorFolks/cyancore
2 participants
@akashkollipara @pranjalchanda08