-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Mill to 0.12.2 #3250
Draft
lolgab
wants to merge
33
commits into
VirtusLab:main
Choose a base branch
from
lolgab:update-mill-0.12
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Update Mill to 0.12.2 #3250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
@lolgab should we bump directly to |
We use Scala3 dialect on all code with Scala 2.13+
@Gedochao I am not hacking on this anymore. I updated to latest mill as you suggested. Feel free to push on the branch if you want to make it to the finish line |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes build files to
.mill
suffix, which requires package definitions (alternatively.mill.scala
can be used which is syntax highlighted by more editors and by GitHub).Since only
build.mill
andpackage.mill
can containModule
s andTarget
s, I movedpublish.sc
topublish/package.mill
andsettings.sc
tosettings/package.mill
Since
runner
is now a member ofRunModule
(extended byScalaModule
, I reference the runner module using it's packagebuild.runner
.Mill 0.12 doesn't use positional arguments by default. This PR changes calls to task from the command line to pass
--argumentName
before all parameters.Dependencies
pwd
as a parameter inUpload.copyLauncher
alexarchambault/mill-native-image#111