Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mill to 0.12.2 #3250

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from
Draft

Update Mill to 0.12.2 #3250

wants to merge 33 commits into from

Conversation

lolgab
Copy link
Contributor

@lolgab lolgab commented Oct 26, 2024

Changes build files to .mill suffix, which requires package definitions (alternatively .mill.scala can be used which is syntax highlighted by more editors and by GitHub).
Since only build.mill and package.mill can contain Modules and Targets, I moved publish.sc to publish/package.mill and settings.sc to settings/package.mill
Since runner is now a member of RunModule (extended by ScalaModule, I reference the runner module using it's package build.runner.
Mill 0.12 doesn't use positional arguments by default. This PR changes calls to task from the command line to pass --argumentName before all parameters.

Dependencies

@Gedochao
Copy link
Contributor

@lolgab should we bump directly to 0.12.1?

@lolgab lolgab changed the title Update Mill to 0.12.0 Update Mill to 0.12.1 Oct 29, 2024
@Gedochao
Copy link
Contributor

Gedochao commented Nov 13, 2024

@lolgab are you still hacking at this? Do you need help?
Seems like 0.12.2 came out in the meantime (#3268), does it make the migration easier?

@lolgab lolgab changed the title Update Mill to 0.12.1 Update Mill to 0.12.2 Nov 13, 2024
@lolgab
Copy link
Contributor Author

lolgab commented Nov 13, 2024

@Gedochao I am not hacking on this anymore. I updated to latest mill as you suggested. Feel free to push on the branch if you want to make it to the finish line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants