-
Notifications
You must be signed in to change notification settings - Fork 41
Migrate theme to new storefront version with Scriban view engine #79
Comments
@tatarincev, i made a commit 1e1c422 to branch with scriban theme and also made a comment VirtoCommerce/vc-storefront#188 (comment) about syntax change,but still have few problems here:
|
* Changes to run theme in scriban templating engine * Remove named arguments for all pipe functions calls (not supported in current scriban template engine) Remove arguments for all Include statements Replace == blank to .empty? == false check * Remove AJAX load for product prices Update theme to work with new data context (not finished) * Changes in syntax to run theme with scriban * Removed custom order collections by 'all-collections' linklist, scriban syntax fix * Sing in link shoing in header. solved. #83 * collection-sidebar.liquid problem was resolved. * Problem "Images and prices for products are not showing" was resolved. #87 * Added indents * Product search functionality is repaired * left code n comments was deleted * product price actual price showing in search and collectiono-list pages * price product snipped was extracted from prduct-grid-item, product-list-item and search-result-grid snippets Due to eliminate duplication * small fix in search.liquid * migration of localization files * static page showing was fixed * properly date showing in blogs page. also corrected another usings of dates filters in liquid and angular markaups * anonymous checkout page showing is fixed * sidbar filter is rapaired. Multiple choise under one agr group. * Process navigation links through absolute_url filter
The primary objective is allow to run the vc-theme-default with the new storefront that powered by new Scriban, end-user liquid template engine
Technical details:
The new storefront version with Scriban engine can be taken from this branch https://github.com/VirtoCommerce/vc-storefront-core/tree/features/scriban-migration
All theme changes should be performed in special branch
scriban-migration
in GitHub repository of this themeAll known breaking changes related with new theme syntax are described in this issue Replace DotLiquid with Scriban templating engine vc-storefront#188
The list of e2e tests that's the new theme must pass
e2e tests.zip
The text was updated successfully, but these errors were encountered: