You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am currently exploring the use of DiT model for diffusion/flow matching and have been reviewing both the LFM and DiT repositories. I have noticed a potential discrepancy in how timesteps are handled between these two implementations, specifically regarding the range of timesteps and their scaling in the timestep_embedding function.
Given the variations in timestep scaling, the resulting embeddings from each model will inherently differ, potentially affecting their performance and behavior.
Could you please clarify if this difference in the range of timesteps is intentional?
Thank you for your help and for the great work on these projects!
Best regards,
Danil.
The text was updated successfully, but these errors were encountered:
Hello,
I am currently exploring the use of DiT model for diffusion/flow matching and have been reviewing both the LFM and DiT repositories. I have noticed a potential discrepancy in how timesteps are handled between these two implementations, specifically regarding the range of timesteps and their scaling in the
timestep_embedding
function.In the DiT repository, timesteps are scaled from 0 to 1000:
https://github.com/facebookresearch/DiT/blob/ed81ce2229091fd4ecc9a223645f95cf379d582b/train.py#L204
However, in the LFM repository, timesteps appear to be taken from a normalized range of 0 to 1:
LFM/train_flow_latent.py
Line 145 in 601fd91
But both repositories use a same
timestep_embedding
function which does not inherently account for different ranges of input timesteps:DiT: https://github.com/facebookresearch/DiT/blob/ed81ce2229091fd4ecc9a223645f95cf379d582b/models.py#L41
LFM:
LFM/models/DiT.py
Line 44 in 601fd91
Given the variations in timestep scaling, the resulting embeddings from each model will inherently differ, potentially affecting their performance and behavior.
Could you please clarify if this difference in the range of timesteps is intentional?
Thank you for your help and for the great work on these projects!
Best regards,
Danil.
The text was updated successfully, but these errors were encountered: