Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add More Nouns! #3

Open
VickiLanger opened this issue Sep 16, 2020 · 11 comments
Open

Add More Nouns! #3

VickiLanger opened this issue Sep 16, 2020 · 11 comments
Assignees
Labels
good first issue Good for newcomers Hacktoberfest Requesting input/assistance from anyone help wanted Extra attention is needed

Comments

@VickiLanger
Copy link
Owner

VickiLanger commented Sep 16, 2020

This will be a running issue to let people know how to add nouns to words_dir/tweet_nouns.py


In the tweet_nouns.py file, there are some nouns separated by comments to have different categories.

All nouns should be singular and lower case (unless a proper noun). (eg boot, not boots)


Nouns must make sense after "{adjective} {label}" (example: tiny queer [something])

Within categories, please keep in alphabetical order.

All nouns added should look like the below

'noun goes here',

If you're adding a new category of items, do it like this

# category name here
'noun goes here',
'noun goes here',
'noun goes here',

Proposed workflow:

  1. Fork this repo
  2. Add answers to words_dir/tweet_nouns.py keeping to the existing style/conventions:
    • Each noun word should be singular (eg boot, not boots)
    • all lower case letters, unless it's a Proper noun
    • follow the examples above
  3. Once you are done and checked for typos, commit it & push your work to your fork
  4. Submit a PR against this repo

Someone will look it over and, if deemed appropriate, will merge your PR.

Thanks for contributing!


Don't forget to follow the bot on Twitter to see the hard work you put in.

@VickiLanger VickiLanger added help wanted Extra attention is needed good first issue Good for newcomers Hacktoberfest Requesting input/assistance from anyone labels Sep 16, 2020
@rexdivakar
Copy link

Hey @VickiLanger can u assign me i will raise a PR after Oct 1st !!

@VickiLanger VickiLanger pinned this issue Sep 26, 2020
@VickiLanger
Copy link
Owner Author

@rexdivakar Sounds great. I look forward to seeing what you add.

@HOD101s
Copy link
Contributor

HOD101s commented Oct 4, 2020

Hey @VickiLanger ! I've made a PR for this issue.
#20

@jhimly jhimly mentioned this issue Oct 5, 2020
@RidhimaKohli
Copy link
Contributor

Can I add more nouns ?

@rexdivakar
Copy link

Hey @VickiLanger may i know the usage of this nouns file ?? If u are looking to add in more may be we can create a database or a json file for easy parsing !! please share ur ideas and ur view ?

@VickiLanger
Copy link
Owner Author

@rexdivakar thanks for the ideas. I've thought about creating a SQLite db for it, but I'm not sure how that would work with open source contributing. I haven't done it before so I'm not sure if it would still work the way it does currently.

Currently, tweet_nouns.py is just a python list that is pulled by get_tweet.py

@rexdivakar
Copy link

If u wish I can work on it ?? @VickiLanger

@VickiLanger
Copy link
Owner Author

VickiLanger commented Oct 6, 2020

I kinda like it the way it is, for now. @rexdivakar

@SanGeeky
Copy link

SanGeeky commented Oct 13, 2020

Hi ! i want to work in your project, can i add my info in the readme.md file ?

And in the future i want to develop a spanish version of your bot or maybe a bot for instagram 🤭

@VickiLanger
Copy link
Owner Author

@SanGeeky that sounds awesome! I've never even thought about Instagram bots. You're welcome to add to the bot and add your name when you do. I'm excited to see what you come up with

@alexnsuarez
Copy link
Contributor

Made a pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Hacktoberfest Requesting input/assistance from anyone help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants