Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: very_good packages get -r stops on first failure #737

Open
eseidel opened this issue May 15, 2023 · 2 comments
Open

feat: very_good packages get -r stops on first failure #737

eseidel opened this issue May 15, 2023 · 2 comments
Labels
feature A new feature or request p3 Issues that we currently consider unimportant

Comments

@eseidel
Copy link

eseidel commented May 15, 2023

Would be nice to have an option to allow very_good to continue after first failure. I love being able to use it to fetch all packages but sometimes there are failures I expect and would like to ignore/continue.

Running inside the Dart SDK:
https://github.com/dart-lang/sdk/wiki/Building#source

eseidel@erics-mbp sdk % very_good packages get -r
✓ Running "flutter packages get" in /Users/eseidel/Documents/GitHub/dart-sdk/sdk/pkg/dart2js_tools (0.5s)
✓ Running "flutter packages get" in /Users/eseidel/Documents/GitHub/dart-sdk/sdk/tools/verify_docs (0.5s)
✓ Running "flutter packages get" in /Users/eseidel/Documents/GitHub/dart-sdk/sdk/tools/package_deps (0.5s)
✓ Running "flutter packages get" in /Users/eseidel/Documents/GitHub/dart-sdk/sdk/runtime/observatory_2 (0.4s)
ProcessException: Standard out
Resolving dependencies...
Standard error
The lower bound of "sdk: '>=2.6.0 <3.0.0'" must be 2.12.0'
or higher to enable null safety.

The current Dart SDK (3.0.0) only supports null safety.

For details, see https://dart.dev/null-safety
  Command: flutter packages get
@eseidel eseidel added the bug Something isn't working as expected label May 15, 2023
@renancaraujo renancaraujo added feature A new feature or request and removed bug Something isn't working as expected labels May 19, 2023
@renancaraujo renancaraujo changed the title fix: very_good packages get -r stops on first failure feat: very_good packages get -r stops on first failure May 19, 2023
@renancaraujo
Copy link
Contributor

All recursive commands are fail fast by design. For this case we can add an option to turn off fail fast.

@eseidel
Copy link
Author

eseidel commented May 19, 2023

I got around this by just passing an increasing number of --ignore commands. If others don't need this, feel free to just close. Simple is good.

@BeatriceMitchell BeatriceMitchell moved this from Needs Triage to Backlog in VGV Open Source 🦄 🧙🌟 May 22, 2023
@tomarra tomarra added the p3 Issues that we currently consider unimportant label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or request p3 Issues that we currently consider unimportant
Projects
Status: Backlog
Development

No branches or pull requests

3 participants