Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distrobox icons broke after updated to Gnome 46 #161

Open
dreamgineer opened this issue Jul 9, 2024 · 10 comments
Open

Distrobox icons broke after updated to Gnome 46 #161

dreamgineer opened this issue Jul 9, 2024 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@dreamgineer
Copy link

dreamgineer commented Jul 9, 2024

Issue Description

I immidiately noticed gnome got updated to version 46 after I booted my laptop one day
But another thing I also noticed is that icons from apx containers are broken, as below
image
Firefox and files are on host, while vscode and spotify(those 2 on right side) are from pico

Steps to Reproduce

  • Update to latest orchid
  • Run an app from pico
  • See the desktop icon being default executable icon on panel/dock/etc.

On what version of Vanilla OS this happens?

22.10 unreleased (Orchid)

Additional Information

No response

@dreamgineer dreamgineer added bug Something isn't working triage labels Jul 9, 2024
@orbit-psd2

This comment was marked as off-topic.

@dreamgineer
Copy link
Author

orbit this aint a joke

@mirkobrombin
Copy link
Member

Can you try re-exporting the apps using vso export -h?

@dreamgineer
Copy link
Author

My gnome crashed as soon as I did vso export -a code

@taukakao
Copy link
Member

Also, this is reproducible even with new desktop entries.
For example running this in the container:

sudo apt install gedit

will install gedit correctly but if you open it it doesn't have an icon.

@taukakao taukakao removed the triage label Jul 10, 2024
@taukakao taukakao moved this to Todo in 2 - Orchid Jul 10, 2024
@taukakao taukakao added this to the 2-after-stable milestone Jul 10, 2024
@jardon
Copy link
Member

jardon commented Aug 31, 2024

Looks like a window tracking issue. Doesnt effect every app. Gimp, for example, shows its icon correctly. I'm guessing this can be fixed during the export process, but I havent looked at it yet.

This can be verified by opening the window and using Alt + F2 to execute lg

Image

@jardon
Copy link
Member

jardon commented Sep 2, 2024

After a reboot i think, the problem sorted itself out in the app list, BUT the problem still persists when launching the application. This is very likely a wmclass issue. I haven't looked at the export process for apps here, but that may be something that we can fix during that process.

Any thoughts?

image

@mirkobrombin
Copy link
Member

The export is managed by distrobox. Could be a bug in there?

@jardon
Copy link
Member

jardon commented Sep 2, 2024

I found several bugs related to this:

If I understand correctly, these are the takeaways:

  1. This only affects applications that run on X11 or Xwayland
  2. distrobox guests have different hostnames than the host so GNOME treats them as remote applications and doesn't match them to the correct application

Potential fixes:

  1. Edit StartupWMClass of application, but that would require reliably applying that to .desktop entries that don't already have it
  2. Rename the .desktop files to omit the guest name
  3. Match distrobox guests hostname to host (requires recreating all guests)

Edit: The link to the solution in the upstream bug is no longer a valid link, but the git history shows a snippet for setting the distrobox guest hostname:

distrobox create --name test --hostname "$(uname -n)" --image your-chosen-image:tag

@jardon jardon self-assigned this Sep 7, 2024
@jardon
Copy link
Member

jardon commented Sep 7, 2024

I have confirmed that renaming the .desktop file works as a workaround. For example:

mv .local/share/applications/apx-vso-pico-org.gnome.gedit.desktop \ 
.local/share/applications/org.gnome.gedit.desktop

Ideally, these applications would be updated to run natively under Wayland, but this works for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

5 participants