Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some wow64 funcs are not working for wg_parser #232

Closed
peterjc123 opened this issue Apr 16, 2024 · 5 comments
Closed

some wow64 funcs are not working for wg_parser #232

peterjc123 opened this issue Apr 16, 2024 · 5 comments

Comments

@peterjc123
Copy link

Fixes: #230 #231

@kisak-valve
Copy link
Member

Hello @peterjc123, you've come across a downstream fork of wine used in Proton. These merge requests look like they should be reviewed and merged into upstream wine (https://gitlab.winehq.org/wine/wine/), and afterwards, if this is needed to fix a game with Proton, you can make a request to backport the accepted commits to Proton's variant of wine.

@peterjc123
Copy link
Author

@kisak-valve Sorry for posting them here. I'll try to get it to upstream wine.

@peterjc123
Copy link
Author

@kisak-valve After a second look, it seems that #230 only works for proton-wine, since the argument flags doesn't appear in upstream wine.

@peterjc123
Copy link
Author

peterjc123 commented Apr 16, 2024

@kisak-valve #231 is similar, since these args flags and uri are only available in proton-wine. That's why those changes are needed in this repo, not the upstream wine.

@peterjc123
Copy link
Author

@kisak-valve And there is another patch, #233. I've checked that it doesn't apply for upstream wine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants