Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max_load input for breaks object not currently supported #71

Open
ejwillemse opened this issue May 3, 2023 · 2 comments
Open

max_load input for breaks object not currently supported #71

ejwillemse opened this issue May 3, 2023 · 2 comments

Comments

@ejwillemse
Copy link

Currently, vroom 1.3.0 supports a max_load input with the breaks object:

[max_load]: an array of integers describing the maximum vehicle load for which this break can happen --- https://github.com/VROOM-Project/vroom/blob/master/docs/API.md

pyvroom 1.3.0 only allows for id, time_windows, service and description (see

def __init__(
):

    def __init__(
        self,
        id: Union[Break, int],
        time_windows: Sequence[TimeWindow] = (),
        service: int = 0,
        description: str = "",
    ) -> None:

Would it be easy to include max_load input with pyvroom as well?

@jonathf
Copy link
Collaborator

jonathf commented May 6, 2023

That is a good catch, and something I missed in the recient release.

I've made a fix in version 1.13.1. Let me know if it works as expected.

@ejwillemse
Copy link
Author

Thanks, I'll do some testing later next week and will close the issue once tested.

@jcoupey jcoupey mentioned this issue May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants