-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom ORS Server Configuration Not Working in PyVroom 1.14.0 #117
Comments
Looking at the code diff between the two versions, VROOM-Project/vroom#1036 seems like a likely suspect, but this isn't my expertise. @jcoupey do you have any thoughts on this? |
Yes, this is where the above mentioned changelog entry comes from and that is likely the reason of the change in behavior. What I don't get is why just adding the missing bit does not work. Can you share the |
Thank you very much for your quick response! When I try to specify the IP with the Seeing this error, I even tried modifying the Thank you again for your help and support with this! |
Can you share the similar "Failed to connect..." error when using:
|
OK, in the latter case, the request is done to The thing is that when using the command-line, there is no way to use ORS without going through the It is in fact not possible to get the same behavior from pyvroom currently by just setting a different host. The way to reproduce the same behavior as when parsing flags would be to somehow expose the A cleaner long-term approach would be to extend the Server struct ctor to allow directly passing an explicit path, then one could simply use something like: servers={
"driving-car": vroom._vroom.Server(host=f"{ORS_IP}", port=PORT, path="/ors/v2")
} |
I have looked at it, and it would be possible to hack an interface through Python, but proper exposing the path as an input to a Server struct constructor is the obvious way to go that should be easy to implement upstream and here. Shall we aim for that @jcoupey? |
@jonathf sure, I just opened a PR, can you please simply confirm the added ctor in VROOM-Project/vroom#1192 will allow to fix the problem for pyvroom? |
@denis-rodriguez, I have made a preview version Do you mind trying the server string format |
Issue: Custom ORS Server Configuration Not Working in PyVroom 1.14.0
Description
First, I want to thank the vroom-project community for the excellent work on this project.
However, I’ve encountered an issue when trying to configure a custom ORS (OpenRouteService) server in version
pyvroom==1.14.0
. The setup does not appear to work as expected, and the application does not connect to the specified server. Using the same code with the previous version,pyvroom==1.13.6
, the configuration works perfectly, and the connection to the custom ORS server is successful.I believe this issue may be related to the change introduced in
vroom
version 1.14.0:(ORS: (previously) hard-coded /ors/v2 slug now has to be added to the path using -a (#1036))
. This adjustment may affect the way custom ORS servers are defined and accessed.I also tried adding
/ors/v2
manually to the server host path, as suggested by the change in version1.14.0
, but the setup still did not work as expected.Steps to Reproduce
Install
pyvroom
version 1.14.0:Run the following code to configure a custom ORS server:
Note that in version
pyvroom==1.14.0
, even with the/ors/v2
path added, the code does not connect to the custom ORS server. However, when switching to versionpyvroom==1.13.6
, the same code works correctly without this modification.Additional Information
3.10
Google Colab (using default configurations)
Comments
Any assistance or guidance on resolving this issue would be greatly appreciated. Thank you!
The text was updated successfully, but these errors were encountered: