Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cherry pick the fix for download-binaries #10

Merged
merged 5 commits into from
Nov 25, 2024
Merged

fix: cherry pick the fix for download-binaries #10

merged 5 commits into from
Nov 25, 2024

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Nov 24, 2024 •
edited
Loading

@decahedron1 @qryxip
fix: concurrent downloads, ref pykeio#322
d61f7d6 
(cherry picked from commit eb51646)

Conflicts:
	ort-sys/build.rs
	ort-sys/src/internal/mod.rs
	src/session/builder/impl_commit.rs
@decahedron1 @qryxip
fix: here's why not to use nightly by default!
1f9d28e 
(cherry picked from commit effd7a7)
@qryxip
Copy link
Member Author

qryxip commented Nov 24, 2024 •
edited
Loading

ortはNightlyのRustfmtでCIされてるんですが、v2.0.0-rc.4ベースのコードだと駄目になってるっぽい。今は無視しかなさそう。
https://github.com/VOICEVOX/ort/actions/runs/11992929409/job/33433343139?pr=10

@qryxip qryxip mentioned this pull request Nov 24, 2024
Merged
@qryxip qryxip marked this pull request as draft November 24, 2024 04:18
@qryxip
Copy link
Member Author

qryxip commented Nov 24, 2024 •
edited
Loading

https://github.com/qryxip/voicevox_core/actions/runs/11993046102

thread 'main' panicked at C:\Users\runneradmin\.cargo\git\checkouts\ort-2994e366294b351c\6db94c1\ort-sys\build.rs:448:34:
failed to extract downloaded binaries: Access is denied. (os error 5)

@qryxip qryxip force-pushed the fix-cherry-pick-fix-for-download-binaries branch from 6db94c1 to 0e5c7ab Compare November 24, 2024 19:09
@qryxip
Copy link
Member Author

qryxip commented Nov 24, 2024 •
edited
Loading

✔️: https://github.com/qryxip/voicevox_core/actions/runs/11998836857

@qryxip qryxip marked this pull request as ready for review November 24, 2024 19:12
Hiroshiba
Hiroshiba approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

マージおまかせします！
ffマージのが良さそう？

@qryxip
Copy link
Member Author

qryxip commented Nov 25, 2024

普通にsquash and mergeしようかなと。cherry-pickを大事に保存してもなという感じなので…

@qryxip qryxip merged commit 17f7413 into VOICEVOX:main Nov 25, 2024
7 checks passed
@qryxip qryxip deleted the fix-cherry-pick-fix-for-download-binaries branch November 25, 2024 14:47
qryxip added a commit to VOICEVOX/voicevox_core that referenced this pull request Nov 26, 2024
@qryxip
chore(deps)!: bump ort (#876)
4fbca30 
Refs: #859, VOICEVOX/ort#8, VOICEVOX/ort#9, VOICEVOX/ort#10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qryxip @Hiroshiba @decahedron1