Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check and improve error messages #7

Open
hdbeukel opened this issue Sep 22, 2023 · 1 comment
Open

Check and improve error messages #7

hdbeukel opened this issue Sep 22, 2023 · 1 comment

Comments

@hdbeukel
Copy link
Collaborator

In #4 we made sure that the workflow fails when motif mapping files are not found. The message doesn't mention the file path where the motif mapping files where expected though. We should include the path MotMapsFile in the error message.

Wait to implement this until #3 is merged to avoid another conflict 😄

@hdbeukel
Copy link
Collaborator Author

hdbeukel commented Sep 28, 2023

In fact we should check all error messages. For example I noticed this is wrong:

de_files = Channel.fromPath("${DE_genes_dir}/*.txt")
                  .ifEmpty { error "Cannot find any directory: ${Set_genes_dir}" }

The error message refers to Set_genes_dir instead of DE_genes_dir. Also it says the directory is not found while it could be the directory is actually there but the files inside it are missing (or have a wrong extension).

@hdbeukel hdbeukel changed the title Print motif mapping file path when not found Check and improve error messages Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant