Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Venom #754

Open
DaveBenham opened this issue Feb 2, 2023 · 28 comments
Open

Venom #754

DaveBenham opened this issue Feb 2, 2023 · 28 comments
Labels

Comments

@DaveBenham
Copy link

Repository: https://github.com/DaveBenham/VenomModules
Version: 2.0.0
Hash: 155e5a579769925584db6217b4480b09b7f28ac5

My first attempt at releasing my first plugin! I hope all is in order. I'm sure you will let me know if I need to make changes.

Thanks

@AndrewBelt
Copy link
Member

Hi @DaveBenham, I suggest removing "Modules" from the slug and name property of the manifest, since all Rack plugins contain modules so this is redundant text in the VCV Library.

Also, the license of VCV CV Mix is CC BY-NC-ND 4.0 which does not allow distributing derivative works, so please fix and submit a new commit hash.

@DaveBenham
Copy link
Author

Sure, thanks - I will make those changes.

I thought my hidden inclusion of CVMIX was OK, based on communication with support. As you can see, I was trying to be open and proactive about this. I had already formally requested an enhancement to the Fundamental CV MIX with support, along with my plans to release my own variant if the enhancement request was declined. Here is my most recent message to Paul -

Hi Paul

Any word on plans for CV Mix?

I've get a version with my requested changes in my new plugin that you can see at https://github.com/DaveBenham/VenomModules/blob/main/README.md#cvmix

Ignore the garish color - I've got three other themes. For some reason I happen to like the red so it is the default.

Anyway, I prefer that the Fundamental CV Mix get updated (the faceplate changes aren't as important, but I do believe the way I show the 10V normalization is effective).
If Andrew makes the knob scaling change (and maybe faceplate change), then I will strip my version from the VenomModulels plugin.
But if Andrew does not want to make the change then I will go ahead and publish my version.

I don't need to see the change in the Fundamental plugin to move forward, I would just like to know the plan.

I hope to publish VenomModules within the next couple weeks

Thanks

And here is Paul's response

Hi Dave,

Apologies for the delay in responding. We are still looking into the issue. One option I could see is releasing your module pack without it or with it hidden, and then releasing your version of CV Mix later, or releasing it soon, and then marking it as hidden and/or deprecated later, but that is entirely your call.

Hope this helps, please let us know if you have any further questions.

Paul Gatt

So I thought all was OK.

Your demand was very clear, and I am in the process of removing my variant of CV MIX. But I am a bit confused now. What would have to change for me to be able to release a similar module? I want to better understand so that I can be the best community member possible.

If you were to enhance Fundamental CV MIX with the knob scaling change, then I would not have any desire to release any form of variant. But even then it would help me understand the rules better if you could describe what changes would make it acceptable, if only from a hypothetical stand point.

Thanks

@cosinekitty
Copy link

What would have to change for me to be able to release a similar module?

I'm kinda barging in here, but maybe it's just a matter of renaming and making it look different enough that it doesn't cause confusion with the VCV Rack mixer?

@DaveBenham
Copy link
Author

Sounds plausible and reasonable, thanks. But I am hoping for a clear direction from Andrew.

@DaveBenham
Copy link
Author

Repository: https://github.com/DaveBenham/VenomModules
Version: 2.0.0
Hash: 4375b8f062ac3d45d35b78dfeec6f77d030a55bb

OK - I've changed the slug and plugin name to Venom, as well as removed CVMIX.

I kept the same initial version. Hopefully that is not a problem.

I think it is ready to go!

I've also deleted all the binary beta releases from my GitHub as they contained the CVMIX.

Andrew, hopefully you can answer my question above to help me with my future efforts. Thanks.

@pgatt
Copy link

pgatt commented Feb 6, 2023

Hi Dave, apologies for the confusion. I didn't write that to authorise you to copying CV Mix in a manner that breaches the Creative Commons Licence, I assumed you would be releasing a module that would be based on CV Mix that would be in line with the Licence.

@cschol cschol reopened this Feb 6, 2023
@cschol cschol changed the title VenomModules Venom Feb 6, 2023
@DaveBenham
Copy link
Author

Sorry Paul, it certainly wasn't my intent to violate any terms. I assumed you had seen what I had and were OK with it. Bad assumption on my part. I still would like clarification on what it would take to with that module to be compliant, even if it never gets released.

@pgatt
Copy link

pgatt commented Feb 6, 2023

I understand Dave.

@DaveBenham
Copy link
Author

Last minute bug fix - I had not updated my Rhythm Explorer preset to account for the recent changes.
I hope this version can go into the next release. Thanks

Version: 2.0.1
Hash: 844dd9fdc68dee34bba73fba88e87ebf5665c758

@AndrewBelt
Copy link
Member

Looks good for VCV Library distribution now!

@cschol
Copy link
Collaborator

cschol commented Feb 11, 2023

Your plugin has been integrated and will be available for all supported platforms with the next Plugin Manager update. Please let us know in this issue when a new version is available. We will reopen it. Thank you for providing your plugin to the Rack community.

@DaveBenham
Copy link
Author

WooHoo! Exciting news for me - thanks!

@DaveBenham
Copy link
Author

A new version is ready for the library with enhancements for existing modules

Repository: https://github.com/DaveBenham/VenomModules
Version: 2.1.4
Hash: 98b13ab27a5ec1ba34310f545915531ccfc5128e

@DaveBenham
Copy link
Author

Venom Version 2.2.0 is ready to be released to the library with 4 new modules.

Repository: https://github.com/DaveBenham/VenomModules
Version: 2.1.4
Hash: e45bd5c25a4d1e2296d13602cc8bf2e05801a4ff

@cschol cschol reopened this Apr 29, 2023
@DaveBenham
Copy link
Author

Venom 2.9.0 is ready for release with 3 new modules, enhancements to 4 modules, and some bug fixes.

Repository: https://github.com/DaveBenham/VenomModules
Version: 2.9.0
Hash: d74a35e71c7ca4444e6e22ab8159033449d975d6

For future reference, I have added @cosinekitty (author of the Sapphire plugin) as a collaborator on the Venom project. Don is authorized to submit update requests here using the same source URL (https://github.com/DaveBenham/VenomModules) on my behalf, should he conclude that I am unreachable or otherwise unable to maintain the Venom plugin. This is to ensure development continuity should anything happen to me. Thank you for your attention in this matter.

@cschol cschol reopened this Aug 23, 2024
@github-project-automation github-project-automation bot moved this from Up-to-date to Integration in VCV Rack Open-source Plugins Aug 23, 2024
@cschol cschol closed this as completed Aug 30, 2024
@github-project-automation github-project-automation bot moved this from Build update to Up-to-date in VCV Rack Open-source Plugins Aug 30, 2024
@DaveBenham
Copy link
Author

Venom 2.9.1 is ready for release. It contains some performance improvements for the Benjolin Osc expanders, plus an option to make the Rungler DAC more closely emulate the original Benjolin.

Repository: https://github.com/DaveBenham/VenomModules
Version: 2.9.1
Hash: b91a8b7227892aa7fae8a15aa1caaa780cc1be21

@AndrewBelt AndrewBelt reopened this Sep 13, 2024
@github-project-automation github-project-automation bot moved this from Up-to-date to Integration in VCV Rack Open-source Plugins Sep 13, 2024
@github-project-automation github-project-automation bot moved this from Build update to Up-to-date in VCV Rack Open-source Plugins Sep 16, 2024
@DaveBenham
Copy link
Author

Venom 2.10.0 is ready for release. It contains 4 new modules, a number of enhancements, plus some bug fixes.

Repository: https://github.com/DaveBenham/VenomModules
Version: 2.10.0
Hash: ffee6798192d7e0907d26c79f7e8d6962b28312a

@cschol cschol reopened this Oct 25, 2024
@github-project-automation github-project-automation bot moved this from Up-to-date to Integration in VCV Rack Open-source Plugins Oct 25, 2024
@github-project-automation github-project-automation bot moved this from Build update to Up-to-date in VCV Rack Open-source Plugins Oct 29, 2024
@DaveBenham
Copy link
Author

Venom 2.11.0 is ready for release. It contains 1 new module, major audio quality enhancements to Poly Fade, and a bug fix.

Repository: https://github.com/DaveBenham/VenomModules
Version: 2.11.0
Hash: f864732977453ff84da46ad2246f645c204356cd

@cschol cschol reopened this Nov 13, 2024
@github-project-automation github-project-automation bot moved this from Up-to-date to Integration in VCV Rack Open-source Plugins Nov 13, 2024
@github-project-automation github-project-automation bot moved this from Build update to Up-to-date in VCV Rack Open-source Plugins Nov 17, 2024
@DaveBenham
Copy link
Author

DaveBenham commented Dec 18, 2024

Venom 2.11.1 is ready for release. It contains improved audio for VCO Lab and VCO Unit, as well as some mixer bug fixes.

Repository: https://github.com/DaveBenham/VenomModules
Version: 2.11.1
Hash: 8740152ce6401a8b9924a623a6801ca7b4b99023

@cschol cschol reopened this Dec 24, 2024
@github-project-automation github-project-automation bot moved this from Up-to-date to Integration in VCV Rack Open-source Plugins Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Integration
Development

No branches or pull requests

5 participants