-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RJModules #507
Comments
Updated build |
My migration to 1.0.0+ is complete! URL: https://github.com/Miserlou/RJModules/ The major new addition, besides the migration, is 'Acid', my take on the TB-303! I'd also really really love it if somebody could take a quick look at: Miserlou/RJModules#38 in case anything jumps out at them.. |
Invalid tag in |
Thank you for reporting those! They should be resolved now, although I don't have a windows machine to test on. |
Okay, the Windows fix (thank you!) and the stability fixes are here, 1.0.0 looks like a go! |
Any chance this can get out today? I'd love to have it be available when I publish my tutorial video. |
No crashes anymore, but FYI, this is still an issue: Miserlou/RJModules#41 |
Thanks! I'm not super concerned about that one until I have access to a
W10+4K setup that I can test it on though, so it's not a blocker for me.
…On Thu, Jul 4, 2019 at 1:47 AM cschol ***@***.***> wrote:
No crashes anymore, but FYI, this is still an issue: Miserlou/RJModules#41
<Miserlou/RJModules#41>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#507?email_source=notifications&email_token=AABCFU7LOOW3RTTEFTTXNH3P5U3ANA5CNFSM4FUBVPH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZF6IGI#issuecomment-508290073>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABCFU65DKKYU5J6NC2Z56DP5U3ANANCNFSM4FUBVPHQ>
.
|
It's happening on Linux on a non-4K system also, just FYI. |
Updated Miserlou/RJModules#41 with a fix for |
Patched. |
Sorry if this is the wrong place, but for me (windows) VCVRack (1.1.1) does not seem to download this plugin specifically from the Plugin library for some reason (others work) (they also don't show up in the user folder). |
It is not in the plugin manager yet. |
Splitter has duplicate port IDs: Miserlou/RJModules#43 |
Okay, what's actually the policy about blockers here? I appreciate your reports, but I wouldn't consider either of those blockers for 1.0, as it's been a week and they're still not available. One of those issues is only for 1.2+ anyway, and the other one is a minor UI quirk that shows up on a bunch of other modules. This 1.0 migration has already been a massive and unfun time sink, can you please just publish these so I can get my tutorial video out? |
I perform a quality audit of plugins before they are integrated in the plugin manager. There are certain criteria (for example missing/invalid fields in If I notice bugs in a module during integration or update, I generally give the developer the chance to fix them because a) it looks unprofessional for the developer and b) it looks unprofessional for the VCV Rack platform if plugins are buggy.
Lastly, if you know of issues in other modules I would appreciate it if you let me know which those are so I can follow up with the developer. |
@Miserlou Can you please specify a SHA to build for this plugin? There appear to have been changes since the announcement 6 days ago. Thanks. |
@Miserlou ping |
Okay, I just added one more, so let's try version 1.7.0 on commit ID |
@Miserlou Did you push the change? I don't see any changes in the repo. |
? This guy: Miserlou/RJModules@fe87c84 |
Something was borked in me local repo. Got it now. |
1.7.2 - Miserlou/RJModules@7db2aad No new modules, but fixes two major crash-on-add and crash-on-remove bugs which were affecting all non-OSX users. |
1.8.0 - adds |
|
Crashes fixed. |
|
@Miserlou Do you have an update on this issue? If not, I will close it for now. Thanks. |
New modules:
The text was updated successfully, but these errors were encountered: