Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite scale_x_continuous() and and scale_y_continuous() #46

Open
awunderground opened this issue Dec 10, 2018 · 3 comments
Open

Overwrite scale_x_continuous() and and scale_y_continuous() #46

awunderground opened this issue Dec 10, 2018 · 3 comments
Assignees
Labels
feature New feature or request

Comments

@awunderground
Copy link
Collaborator

The panel design for urbnthemes differs from most ggplot2 themes. This means there is typically a vertical gap between the bottom of the panel and the bottom horizontal grid line. The introduction of expand_scale() simplifies calculating the range of axes and I typically do something like this:

  scale_x_continuous(expand = expand_scale(mult = c(0.002, 0)), 
	                   limits = c(0, 7),
	                   breaks = 0:7) +
  scale_y_continuous(expand = expand_scale(mult = c(0, 0.002)),
                     limits = c(0, 60)) +  

Should I set expand = expand_scale(mult = c(0.002, 0)) as the default for scale_x_continuous() and scale_y_continuous()?

@awunderground awunderground added the feature New feature or request label Dec 10, 2018
@awunderground
Copy link
Collaborator Author

scale_x_continuous(expand = expand_scale(mult = c(0, 0.1))

scale_y_continuous(expand = expand_scale(mult = c(0, 0.1))

@awunderground
Copy link
Collaborator Author

@khueyama Is this a terrible idea?

@khueyama
Copy link
Contributor

@khueyama Is this a terrible idea?

@awunderground This is similar to what we do in geoms.R right? Seems worth testing to at least see if it's terrible or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants