Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: FullRange missing access controls (security bug) #71

Closed
ferencdg opened this issue Nov 14, 2023 · 1 comment · May be fixed by #128
Closed

[Bug]: FullRange missing access controls (security bug) #71

ferencdg opened this issue Nov 14, 2023 · 1 comment · May be fixed by #128
Labels
bug Something isn't working

Comments

@ferencdg
Copy link

Describe the bug

beforeInitialize should check if it is called by the PoolManager and revert if it isn't

In the current version anyone can override the liquidityToken in the poolInfo

Expected Behavior

only PoolManager should be able to call it

To Reproduce

No response

Additional context

No response

@ferencdg ferencdg added the bug Something isn't working label Nov 14, 2023
@Jun1on Jun1on linked a pull request Jun 24, 2024 that will close this issue
@saucepoint
Copy link
Collaborator

Hi! thanks for flagging -- going to close this issue because:

hook examples no longer live in the main branch

custom accounting will allow for a more v2-style curve with v2 interfaces. reference implementation https://github.com/hensha256/v2-on-v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants