Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move gas snapshots to snapLastCall and forge test --isolate #113

Closed
saucepoint opened this issue May 20, 2024 · 1 comment
Closed

Move gas snapshots to snapLastCall and forge test --isolate #113

saucepoint opened this issue May 20, 2024 · 1 comment
Labels
good first issue Good for newcomers v4 deployer comp

Comments

@saucepoint
Copy link
Collaborator

Component

General design optimization (improving efficiency, cleanliness, or developer experience)

Describe the suggested feature and problem it solves.

To align with v4-core and produce more reliable gas benchmarks, we should use snapLastCall and forge test --isolate

Describe the desired implementation.

No response

Describe alternatives.

No response

Additional context.

No response
@saucepoint saucepoint added the good first issue Good for newcomers label May 20, 2024
@linear Linear
Copy link

linear bot commented May 20, 2024

PROTO-218 Move gas snapshots to `snapLastCall` and `forge test --isolate`

@Jun1on Jun1on linked a pull request Jun 26, 2024 that will close this issue
Move gas snapshots to snapLastCall and forge test --isolate #131
Closed
@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers v4 deployer comp
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move gas snapshots to snapLastCall and forge test --isolate Uniswap/v4-periphery
1 participant
@saucepoint