Upgrade test container image to Ubuntu 24.04 #3255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of gosu will complain loudly about having the setuid bit set, and refuse to work. gosu is not really intended to raise the privilege level of the calling user, but to lower it. This switches up the use of the test docker image and gosu, running the container as root by default, but instead using the entrypoint script to modify the `build` user and then *drop* privileges to that user before running the container command.
Newer Docker versions will complain about the legacy ENV syntax if used, so it's time to switch.
Install the unzip package with basic system packages to reduce number of apt-get install commands used in image.
This should speed up rebuilds by retaining an apt package cache between builds of the test image.
Ubuntu has changed how its package lists are specified by default. It also ships with libsnmp40 rather than libsnmp35. Finally, the most important change is that pip no longer is allowed to install Python packages globally, so tox and its associates are instead installed to a virtualenv whose bin directory is added to the default PATH of the container.
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
|
Test results 9 files 9 suites 8m 25s ⏱️ Results for commit 74209c6. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3255 +/- ##
==========================================
- Coverage 60.55% 60.54% -0.01%
==========================================
Files 606 606
Lines 43723 43723
Branches 48 48
==========================================
- Hits 26478 26474 -4
- Misses 17233 17237 +4
Partials 12 12 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades the test container image used for local integration testing to Ubuntu 24.04, which brings it more in line with the current
ubuntu-latesttag used on Github Actions.It also fixes some problems with the image, highlighted by the upgrade to Ubuntu 24:
The way privilege escalation for management inside the container works has been turned on its head. The container now starts privileged and drops to a non-privileged user after startup-maintenance has been performed. The main way to elevate privileges inside the container is now through
sudo, notgosu(which claims it was never intended for privilege escalation and will not not work if you try it).Cache mounts for APT packages are added to the definition, in an attempt to make image builds faster.
Syntax problems/deprecations highlighted by newer Docker versions have been fixed
Just as newer Debian versions have started to do, newer Ubuntu versions will refuse to let
pipinstall site-wide packages, in order to avoid breaking the OS' own Python packages. The image therefore switches to using a virtualenv for the few Python commands we need to drive tox and the test suite.