Add custom basic form templates #3034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3034 +/- ##
==========================================
- Coverage 60.47% 60.45% -0.02%
==========================================
Files 605 605
Lines 43816 43818 +2
Branches 48 48
==========================================
- Hits 26497 26490 -7
- Misses 17307 17316 +9
Partials 12 12 ☔ View full report in Codecov by Sentry. |
podliashanyk
force-pushed
the
add-custom-basic-form-templates
branch
from
5dc3632 to
70f3d83
Compare
podliashanyk
force-pushed
the
add-custom-basic-form-templates
branch
from
02301b6 to
845ef63
Compare
podliashanyk
force-pushed
the
add-custom-basic-form-templates
branch
from
548cf02 to
d54ecfe
Compare
This was referenced Sep 26, 2024
lunkwill42
requested changes
Sep 27, 2024
|
lunkwill42
requested changes
Sep 27, 2024
lunkwill42
approved these changes
Sep 27, 2024
lunkwill42
added a commit
that referenced
this pull request
Sep 27, 2024
This uses the form mechanisms that were introduced in #3034 to replace crispy-forms.
lunkwill42
added a commit
that referenced
this pull request
Sep 27, 2024
This uses the form mechanisms that were introduced in #3034 to replace crispy-forms.
lunkwill42
added a commit
that referenced
this pull request
Sep 27, 2024
This uses the form mechanisms that were introduced in #3034 to replace crispy-forms.
johannaengland
pushed a commit
that referenced
this pull request
Oct 1, 2024
This uses the form mechanisms that were introduced in #3034 to replace crispy-forms.
johannaengland
pushed a commit
that referenced
this pull request
Oct 3, 2024
This uses the form mechanisms that were introduced in #3034 to replace crispy-forms.
lunkwill42
added a commit
that referenced
this pull request
Oct 3, 2024
This uses the form mechanisms that were introduced in #3034 to replace crispy-forms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds basic reusable form building blocks for #2794.
Note:
set_flat_form_attributes()is meant to replace crispy FormHelper but keeping only relevant subset of attributes and logic. Just add more attributes toset_flat_form_attributesif needed./custom_crispy_templates/_form_content.htmlcan be included in template directly (withoutflat_form.htmlwrapper) when uncrispyfying forms that are initialised withself.helper.form_tag = FalseCss classes and tag attributes in new templates are meant to work as minimally viable reimplementation of: