Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress secret API tokens in log messages by PaloaltoArp ipdevpoll plugin #3251

Open
jorund1 opened this issue Nov 29, 2024 · 0 comments
Open

Suppress secret API tokens in log messages by PaloaltoArp ipdevpoll plugin #3251

jorund1 opened this issue Nov 29, 2024 · 0 comments
Labels
bug

Comments

@jorund1
Copy link
Collaborator

jorund1 commented Nov 29, 2024

Also, we need to make a separate issue for something entirely unrelated to this PR: This logs the full contents of the secret API token, which is generally not a good idea from a security standpoint. It should be censored. Would you do the honors?

Originally posted by @lunkwill42 in #3147 (comment)
@jorund1 jorund1 changed the title Suppress URLs in log messages from PaloaltoArp ipdevpoll plugin Suppress full URLs in log messages from PaloaltoArp ipdevpoll plugin Nov 29, 2024
@jorund1 jorund1 mentioned this issue Nov 29, 2024
Open
@lunkwill42 lunkwill42 added the bug label Dec 6, 2024
@lunkwill42 lunkwill42 changed the title Suppress full URLs in log messages from PaloaltoArp ipdevpoll plugin Suppress secret API tokens in log messages by PaloaltoArp ipdevpoll plugin Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lunkwill42 @jorund1