Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serial line not usable as human interface, really? #131

Closed
taliesin opened this issue Feb 19, 2018 · 4 comments
Closed

serial line not usable as human interface, really? #131

taliesin opened this issue Feb 19, 2018 · 4 comments

Comments

@taliesin
Copy link

Hi,

I just tried to use the serial interface and found it unusable from the terminal.
The reason (in main.c) being:
int len = uart_readline(serial_cmd, 255);
returns immediately after a single character, which only works for '?'

As far as I can understand this call should be non-blocking as it would block the keyboard interface otherwise. So this needs some kind of re-write, I think.
I'm feeling like I'm missing a point somewhere, how could it ever work the way it's done?!

Helmut

@taliesin
Copy link
Author

Just found Issue #22 which already states the problem.
I'm prepared to take some effort here, any further suggestions?
Probably I'll try to plug in a little shell like from ChibiOS: http://chibios.sourceforge.net/html/group___s_h_e_l_l.html

Helmut

@GitLang
Copy link

GitLang commented Feb 20, 2018

A pre made and tested shell is a good idea. Did I get the wrong idea or does that shell only receive data and not transmit?. I could see shellGetLine() but not shellPutLine()

@taliesin
Copy link
Author

It simply uses chprintf() a ChibiOS specific output (resembling printf but working on a chibi stream).
I'm currently dissecting the main working thread to be able to plug it in.

@taliesin
Copy link
Author

Porting the ChibiOS shell did not go well, I used SimpleCLI instead (see my pull request).
This is therefore considered closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants