-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving forward #46
Comments
Hi Sean, yes - definitely still interest in merging those code bases. I'll add @noaaroland to this thread. |
Please let me know if there is something you need me to do. Happy to test command-line release candidates. |
PR #47 has the refactored codebase, although it might be a little easier to see on my branch over at https://github.com/lesserwhirls/threddsIso/tree/refactor. A lot of the code in the https://github.com/NOAA-PMEL/uafnciso/ repository lives in the If you'd like to try the command line jar produced by the code in my PR, you can snag it here. |
I downloaded the jar and it performs as expected on the examples I tried. We will probably do more extensive testing by putting the jar in our regular process for building ISO metadata. I will note that the CDN links I baked into my code for the software to download the XSLTs have certificate/gateway problems. I struggled with how to provide those files and two attempts to find a good CDN for a github file both failed. I hope you have some better ideas on how to host those file. |
In the process of updating the
threddsIsoTds5
branch of this repo to use the latest version of netCDF-Java (and the proposed public API), I noticed a few things that are still not quite right with respect to coming in-line with ncIso. Of course, the transforms being out of sync are still an issue. However, there are a few more things as well. I'd really like to bring this repo up-to-speed, but it's not exactly clear where things stand in general. The initial steps for combining the codebases of ncIso and threddsIso have been done. The next step will be to refactor the layout of this repository to become a maven multi module project, which will allow us to produce a stand-alone ncIso jar cleanly along-side the plugin for the TDS.So, as a conversation starter - is there still interest to have the two codebases combined and managed in one location?
The text was updated successfully, but these errors were encountered: