Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove material_print_temperature from sovol_base_planetary.def.json #16856

Closed
wants to merge 1 commit into from

Conversation

mstrent
Copy link

@mstrent mstrent commented Oct 1, 2023

Description

material_print_temperature should not be defined at the printer level as it overrides material default print temperature. Every gcode file comes out at 195* unless this setting is removed here, regardless of your material settings.

Type of change

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [x ] Printer definition file(s)
  • Translations

How Has This Been Tested?

Tested by editing this file on the installed version of Cura on my PC. After this setting is removed at the printer definition level, the default temperature setting at the material definition level actually affects the final product, as you would expect.

This should not be defined at the printer level as it overrides material default print temperature. Every gcode file comes out at 195* unless this setting is removed here, regardless of your material settings.
@mstrent
Copy link
Author

mstrent commented Oct 1, 2023

This is a duplicate of, and fixes one less problem than #16107. Though I've only tested the temperature part.

@MariMakes MariMakes added the PR: Printer Definitions 🏭 A PR that introduces or changes settings and printer definitions label Oct 11, 2023
@nallath
Copy link
Member

nallath commented Nov 29, 2023

Closing this in favor of #16107

@nallath nallath closed this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's PR: Printer Definitions 🏭 A PR that introduces or changes settings and printer definitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants