Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Elegoo Neptune 4 Pro #16608

Closed
wants to merge 2 commits into from

Conversation

Ev1dentFir3
Copy link
Contributor

@Ev1dentFir3 Ev1dentFir3 commented Aug 29, 2023

Description

This adds support for the Elegoo Neptune 4 Pro printer. Created elegoo_neptune_4pro.def.json for Neptune 4 Pro profile.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Printer definition file(s)
  • Translations

How Has This Been Tested?

  • Test A - Setup as Custom FFF printer, and used the g-code provided by Elegoo in their skinned version of Cura.
  • Test B - Printed multiple parts with Custom FFF profile to test g-code.

Test Configuration:

  • Operating System: Windows 11 Cura 5.4.

Checklist:

Create elegoo_neptune_4pro.def.json for Neptune 4 Pro profile.
@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Aug 29, 2023
Corrected missing "value" key in "speed_travel" object on line 35
@mordilion
Copy link

I tried to use the definition with Cura 5.4.0, but it didn't work. Somehow the Nozzle setting is missing. What am I overseen here? @Ev1dentFir3

@BremerButjer
Copy link

tested the json on my cura 5.4:
Printhead settings are not correct. (i thik this is probably because of elegoo base)
and can´t use a profile because missing nozzle size.

@MariMakes MariMakes added the PR: Printer Definitions 🏭 A PR that introduces or changes settings and printer definitions label Sep 5, 2023
@jg506
Copy link

jg506 commented Sep 7, 2023

To fix empty nozzle list, need to create n4p folder under resources/variants. I simply copied the n3p folder, then renamed the folder, each file name and text inside each cfg file. Changed 3 to 4. @mordilion @BremerButjer

@2eQTu
Copy link

2eQTu commented Sep 18, 2023

What is needed for the project to validate the proposed changes and get this PR merged? I've got a Neptune 4 Pro but being new to the space I'm not too confident in evaluating the correctness myself before patching/updating my own copy.

@jg506
Copy link

jg506 commented Sep 18, 2023

@2eQTu the PR cannot be merged yet. @Ev1dentFir3 need to add the missing resources/variants/elegoo/elegoo_neptune_4pro folder which I attached here.
elegoo_neptune_4pro.zip

@ToasterUwU
Copy link

Excited for this.
Elegoo doesn't have a Linux version of their (pretty old) cura version. Using it trough wine works, but isnt ideal for obvious reasons.
So having a version that is not only up to date, but also has a native Linux version would be awesome.

@fuji97
Copy link
Contributor

fuji97 commented Sep 24, 2023

The author @Ev1dentFir3 hasn't updated this PR for one month. Should we wait or fork and update it ourselves?

@jg506
Copy link

jg506 commented Sep 24, 2023

I'm using this without issues for about 30 prints now.

@ToasterUwU
Copy link

The author @Ev1dentFir3 hasn't updated this PR for one month. Should we wait or fork and update it ourselves?

i think someone else needs to take this over. Since the original creator has not interacted with this even once since they made it.

@fuji97
Copy link
Contributor

fuji97 commented Sep 25, 2023

I forked the PR at #16608 and added the missing variant files.
@Ev1dentFir3 if you want to take back the PR just tell me and I'll remove mine.

@2eQTu
Copy link

2eQTu commented Sep 28, 2023

See #16819

@repomanz
Copy link

@2eQTu the PR cannot be merged yet. @Ev1dentFir3 need to add the missing resources/variants/elegoo/elegoo_neptune_4pro folder which I attached here. elegoo_neptune_4pro.zip

Will this work with the neptune 4 max?

@saumyaj3 saumyaj3 closed this Nov 1, 2023
saumyaj3 added a commit that referenced this pull request Nov 1, 2023
Adding support for Elegoo Neptune 4 Pro (#16608 follow-up)
@saumyaj3
Copy link
Contributor

saumyaj3 commented Nov 1, 2023

implemented here: #16819

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's PR: Printer Definitions 🏭 A PR that introduces or changes settings and printer definitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants