Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite MFA function #82

Open
mar235av opened this issue Aug 19, 2024 · 0 comments
Open

Rewrite MFA function #82

mar235av opened this issue Aug 19, 2024 · 0 comments
Assignees

Comments

@mar235av
Copy link
Contributor

The use (or not) of MFA in our Shibboleth deployment is controlled by a 450 line Javascript function with confusing logic flow. This is not even close to good coding practice, is error prone and difficult to modify when needed. On the positive side, we do have rigorous automated testing that establishes that this code works as intended, so the risk is contained.

Best practice would be to re-write this function as a Java plugin with rigorous design and logic flow with unit tests for confirmation. This is likely 1-2 weeks of work.

An alternative is to not do this work in anticipation that some other system would take over the MFA logic, allowing us to retire this function rather than re-writing it.

@mar235av mar235av self-assigned this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant