This repository has been archived by the owner on Sep 28, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 68
Some quotation symbols stripped from comment lines #373
Comments
I've attached an input file consisting of three junctions and associated comment lines. The Delphi GUI resaves it faithfully along with expected additional sections. In the Python GUI I observe the following:
Conceivably items 2 and 3 are new issues, but I'm using the Jan 21 build, so perhaps these have been addressed. If not let me know and I can create additional issues. |
PaulDudaRESPEC
added a commit
that referenced
this issue
May 20, 2020
…omment handling, strip out non-ascii characters in inp file, addresses some of issue #373
Enhanced the code to make it more robust when it hits non-ascii characters and better save comments. The remaining issues mentioned here are stylistic, not bugs, in fact official swmm examples (for example Example1.inp) use this style. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Some types of single (e.g. can’t find problem) and double (e.g. 64” opening) quotation marks are altered in Description lines upon export to .inp. E.g.
;Sediment from 2019 inspection; Updated to reflect 64” opening on 72" pipe
becomes
;Sediment from 2019 inspection; Updated to reflect 64� opening on 72" pipe
;Can’t find elevations should be on 74-24
becomes
;Can�t find elevations should be on 74-24
extremely small (1-3”)
becomes
extremely small (1-3”)
The problem seems to be that there are two kinds of quote symbols.
(I've removed what I thought was the same issue relating to problems reading [Inflows]. Will post new issue
The text was updated successfully, but these errors were encountered: