Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One component per file #8

Open
romaintailhurat opened this issue Nov 4, 2016 · 3 comments
Open

One component per file #8

romaintailhurat opened this issue Nov 4, 2016 · 3 comments
Assignees

Comments

@romaintailhurat
Copy link
Contributor

I think we should systematically split components file in order to have one React component per file.

For example, this one needs a bit of cleaning.

@FranckCo
Copy link
Contributor

I'm not sure I agree with this. There are already a lot of files, it is easy to lose oneself. One file for a function (e.g. 'explore the GSBPM' in the example) seems like a good option to me.

@romaintailhurat
Copy link
Contributor Author

Could be an option, but my first reaction was to avoid diverging from a standard practice, even an implicit one.

If we want a new policy, i think we should document it.

@romaintailhurat
Copy link
Contributor Author

romaintailhurat commented Nov 13, 2016

Another solution could be to group components related to a particular feature :

/components
    /gsbpm
        gsbpm-explorer.js
        ...
    /gsim
    ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants