Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] use of _customPathPrefix is creating links with additional / #267

Closed
edhamiltonHO opened this issue Sep 19, 2023 · 0 comments · Fixed by #268
Closed

[BUG] use of _customPathPrefix is creating links with additional / #267

edhamiltonHO opened this issue Sep 19, 2023 · 0 comments · Fixed by #268
Assignees
Labels
ACP-migration Relating to moving the repo to ukhomeoffice and ACP bug Something isn't working

Comments

@edhamiltonHO
Copy link
Contributor

Describe the bug
In the phase banner the updated feedback link from #263 is https://ho-cto.github.io/engineering-guidance-and-standards//provide-feedback/

This is because that link is generated by concatenating the _customPathPrefix with /provide-feedback/

This is also happening in links in footer items, and the img source link for the organisation logo in the header. It may be happening in other areas and should be investigated.

Expected behavior
Links should not include additional /

Additional context
As the use of _customPathPrefix will likely change during migration to new hosting, this should be fixed as part of that process.

@edhamiltonHO edhamiltonHO added bug Something isn't working ACP-migration Relating to moving the repo to ukhomeoffice and ACP labels Sep 19, 2023
@keithkennedyHO keithkennedyHO self-assigned this Sep 21, 2023
@keithkennedyHO keithkennedyHO linked a pull request Sep 21, 2023 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACP-migration Relating to moving the repo to ukhomeoffice and ACP bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants