Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is expandable banner self-contained? #398

Open
tomyems opened this issue Jul 1, 2022 · 3 comments
Open

Is expandable banner self-contained? #398

tomyems opened this issue Jul 1, 2022 · 3 comments

Comments

@tomyems
Copy link
Contributor

tomyems commented Jul 1, 2022

I believe the expandable banner might not be self-contained.

There's isn't the triangle on the left of the banner expandable banner styling

The triangle on the left of the banner comes from the Details component from NotGov.

This means that you can't just take the expandable banner styling with the HTML snippet from the expandable banner component page.

@daniel-ac-martin
Copy link
Collaborator

daniel-ac-martin commented Jul 3, 2022

Hi @tomyems.
I'm pretty sure that it doesn't use the styling from <Details>.
Are you just confused because you can't find the styling for the triangle in the SCSS code?

I'm fairly sure that's an HTML5 thing. i.e. It comes from the browser.
(I can't see it in govuk-frontend either: https://github.com/alphagov/govuk-frontend/blob/main/src/govuk/components/details/_index.scss )
(Update: It's here: https://github.com/alphagov/govuk-frontend/blob/main/src/govuk/components/details/_index.scss#L66 )

Are you encountering a particular problem? Can you share a screenshot?

@daniel-ac-martin
Copy link
Collaborator

Oh the NotGovUK component, does override the default <details>.
Possibly, that is the issue.

In that case, we might need to add some more code into ExpandableBanner.scss.

@daniel-ac-martin
Copy link
Collaborator

(Basically, you are right, leave it with me.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants