Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility issue 2 - missing caption element for tables in Props #256

Open
karypun opened this issue Jun 23, 2021 · 1 comment
Open

Accessibility issue 2 - missing caption element for tables in Props #256

karypun opened this issue Jun 23, 2021 · 1 comment
Labels
accessibility bug

Comments

@karypun
Copy link
Contributor

karypun commented Jun 23, 2021

Pages affected: all component pages
Issue: Missing element for tables within "Props" click to reveal. Found on every components page.
Resolution: Add in caption element
@daniel-ac-martin
Copy link
Collaborator

For future reference, this could be fixed by providing a caption prop here: https://github.com/daniel-ac-martin/NotGovUK/blob/master/lib/docs-components/src/Props.tsx#L41

In the GDS system they use the caption, "Primary options".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daniel-ac-martin @karypun