diff --git a/apps/collection/fields/index.js b/apps/collection/fields/index.js index 8836b404..685b7295 100644 --- a/apps/collection/fields/index.js +++ b/apps/collection/fields/index.js @@ -5,24 +5,21 @@ const countries = [''].concat(require('../../../assets/countries').allCountries) module.exports = { 'collection-where-radio': { + isPageHeading: true, mixin: 'radio-group', validate: ['required'], - className: ['inline', 'form-group'], - legend: { - className: 'visuallyhidden' - }, + className: ['govuk-radios--inline', 'govuk-form-group'], options: [{ - value: 'Post Office', - toggle: 'collection-date-group' + value: 'Post Office' }, { - value: 'Sponsor', - toggle: 'collection-date-group' + value: 'Sponsor' }] }, 'collection-date': date('collection-date', { validate: ['before'] }), 'reason-radio': { + isPageHeading: true, mixin: 'radio-group', validate: ['required'], options: [{ @@ -53,12 +50,10 @@ module.exports = { }, { value: 'no-brp' - }], - legend: { - className: 'visuallyhidden' - } + }] }, 'nominated-fullname': { + className: ['govuk-input', 'govuk-!-width-two-thirds'], validate: ['required'] }, 'nominated-nationality': { @@ -68,6 +63,7 @@ module.exports = { hint: 'fields.nominated-nationality.hint' }, 'nominated-id-number': { + className: ['govuk-input govuk-!-width-two-thirds'], validate: ['required'] }, 'nominated-date': date('nominated-date', { @@ -75,6 +71,7 @@ module.exports = { validate: ['required', 'before'] }), fullname: { + className: ['govuk-input govuk-!-width-two-thirds'], validate: ['required', 'notUrl'] }, 'date-of-birth': date('date-of-birth', { @@ -87,6 +84,10 @@ module.exports = { hint: 'fields.nationality.hint' }, passport: { + className: ['govuk-input', 'govuk-!-width-two-thirds'], validate: ['required', 'notUrl'] + }, + 'org-help-radio': { + className: ['govuk-radios--inline'] } }; diff --git a/apps/collection/translations/src/en/fields.json b/apps/collection/translations/src/en/fields.json index 96c6e68e..e50abf03 100644 --- a/apps/collection/translations/src/en/fields.json +++ b/apps/collection/translations/src/en/fields.json @@ -14,6 +14,8 @@ "label": "Year" }, "collection-where-radio": { + "legend": "From where were you asked to collect your BRP?", + "hint": "This could have been from a Post Office branch or a sponsor, such as your legal representative, employer, university or school.", "options": { "Post Office": { "label": "Post Office" @@ -24,6 +26,7 @@ } }, "reason-radio": { + "legend": "Why couldn't you collect your BRP?", "options": { "under-age": { "legend": "I am under 18 and attempted collection without my responsible adult", diff --git a/apps/collection/translations/src/en/pages.json b/apps/collection/translations/src/en/pages.json index 30af868d..01ec0d02 100644 --- a/apps/collection/translations/src/en/pages.json +++ b/apps/collection/translations/src/en/pages.json @@ -1,14 +1,11 @@ { "reasons": { - "header": "Why couldn't you collect your BRP?" }, "nominated": { "header": "Who was supposed to collect your BRP on your behalf?", "description": "Provide details of the person who tried to collect the BRP on your behalf" }, "where": { - "header": "From where were you asked to collect your BRP?", - "description": "This could have been from a Post Office branch or a sponsor, such as your legal representative, employer, university or school.", "date-question": "If you have attempted to collect your BRP, when was it? (optional)" }, "contact-details": { @@ -23,7 +20,7 @@ "subheader": "We need these details to process your request." }, "check-details": { - "header": "Check the details you have provided", + "legend": "Check the details you have provided", "subheader": "If any information is incorrect, you can change it here.", "table": { "headers": { @@ -46,6 +43,7 @@ }, "org-details-group": { "header": "What are your details?", + "subheader": "We will attempt to contact the BRP holder directly. We will only use these details to contact you if needed.", "type": "Type of support" }, "footer": { @@ -101,4 +99,5 @@ "someone-else-confirmation": { "paragraph": "We will review the information you have provided and investigate the situation." } + } diff --git a/apps/collection/views/confirm.html b/apps/collection/views/confirm.html index 0ad65b2e..5c6f2a38 100644 --- a/apps/collection/views/confirm.html +++ b/apps/collection/views/confirm.html @@ -13,19 +13,10 @@ {{> partials-navigation}} {{/propositionHeader}} -{{$title}} - {{#t}}journeys.collection.pages.check-details.header{{/t}} -{{/title}} - -{{$header}} - {{

{{#t}}pages.check-details-error.header{{/t}}

+

{{#t}}journeys.collection.pages.check-details.subheader{{/t}}

{{ diff --git a/apps/collection/views/partials/collection-date.html b/apps/collection/views/partials/collection-date.html new file mode 100644 index 00000000..5791392b --- /dev/null +++ b/apps/collection/views/partials/collection-date.html @@ -0,0 +1,20 @@ +
+ + + {{#t}}fields.collection-date.legend{{/t}} + +
+ {{#errors.collection-date}} + + {{errors.collection-date.message}} + + {{/errors.collection-date}} + +
+

{{#t}}pages.where.date-question{{/t}}

+

{{#t}}fields.collection-date.hint{{/t}}

+ {{#input-date}}collection-date{{/input-date}} +
+
+ +
" \ No newline at end of file diff --git a/apps/collection/views/personal-details.html b/apps/collection/views/personal-details.html index be773ec0..80b02483 100644 --- a/apps/collection/views/personal-details.html +++ b/apps/collection/views/personal-details.html @@ -17,13 +17,9 @@ {{#t}}journeys.collection.pages.personal-details.header{{/t}} {{/title}} - {{$header}} - {{{{#t}}journeys.collection.pages.personal-details.subheader{{/t}}

diff --git a/apps/collection/views/reasons.html b/apps/collection/views/reasons.html index b1f02128..506f617b 100644 --- a/apps/collection/views/reasons.html +++ b/apps/collection/views/reasons.html @@ -13,18 +13,6 @@ {{> partials-navigation}} {{/propositionHeader}} - {{$title}} - {{#t}}pages.reasons.header{{/t}} - {{/title}} - - {{$header}} - {{ partials-navigation}} {{/propositionHeader}} - {{$title}} - {{#t}}pages.where.header{{/t}} - {{/title}} - - {{$header}} - {{{{#t}}pages.where.description{{/t}}

{{ partials-navigation}} {{/propositionHeader}} -{{$title}} - {{#t}}pages.check-details-error.header{{/t}} -{{/title}} - -{{$header}} - {{

{{#t}}pages.check-details-error.header{{/t}}

+

{{#t}}pages.check-details-error.subheader{{/t}}

{{{{#t}}pages.check-details-error.corrected-details-table.title{{/t}} +

{{#t}}pages.check-details-error.corrected-details-table.title{{/t}}

{{#values.first-name-error}} diff --git a/apps/correct-mistakes/views/location-applied.html b/apps/correct-mistakes/views/location-applied.html index 336a7341..a969b3d7 100644 --- a/apps/correct-mistakes/views/location-applied.html +++ b/apps/correct-mistakes/views/location-applied.html @@ -14,21 +14,7 @@ {{> partials-navigation}} {{/propositionHeader}} - {{$title}} - {{#t}}journeys.error.location-applied.header{{/t}} - {{/title}} - - {{$header}} - {{{{#t}}journeys.error.location-applied.subheader{{/t}}

{{ partials-navigation}} {{/propositionHeader}} -{{$title}} - {{#t}}pages.same-address.header{{/t}} -{{/title}} - -{{$header}} - {{

{{#t}}pages.check-details.header{{/t}}

{{#t}}pages.check-details.subheader{{/t}}

{{

{{#t}}pages.inside-uk.header{{/t}}

{{#radio-group}}inside-uk{{/radio-group}}
diff --git a/apps/not-arrived/behaviours/change-path.js b/apps/not-arrived/behaviours/change-path.js index b876a5a3..6e812cec 100644 --- a/apps/not-arrived/behaviours/change-path.js +++ b/apps/not-arrived/behaviours/change-path.js @@ -3,7 +3,7 @@ module.exports = superclass => class LetterRecieved extends superclass { saveValues(req, res, next) { - if(req.form.values.collection === 'yes') { + if(req.form.values['post-office-collect-radio'] === 'yes') { res.redirect('/collection/where'); res.end(); }else{ diff --git a/apps/not-arrived/fields/consignment-number.js b/apps/not-arrived/fields/consignment-number.js index 9ef744da..ae71a29c 100644 --- a/apps/not-arrived/fields/consignment-number.js +++ b/apps/not-arrived/fields/consignment-number.js @@ -2,9 +2,10 @@ module.exports = { 'consignment-number-radio': { + isPageHeading: true, mixin: 'radio-group', validate: ['required'], - className: ['inline', 'form-group'], + className: ['govuk-radios--inline', 'form-group'], legend: { className: 'visuallyhidden' }, @@ -17,6 +18,7 @@ module.exports = { ] }, 'consignment-number': { + className: ['govuk-input govuk-!-width-two-thirds'], validate: [{type: 'maxlength', arguments: 22}, 'notUrl'], dependent: { field: 'consignment-number-radio', diff --git a/apps/not-arrived/fields/index.js b/apps/not-arrived/fields/index.js index 2702f3da..7a4b859e 100644 --- a/apps/not-arrived/fields/index.js +++ b/apps/not-arrived/fields/index.js @@ -5,5 +5,6 @@ const _ = require('underscore'); module.exports = _.extend( require('./letter-received'), require('./address-match'), - require('./consignment-number') + require('./consignment-number'), + require('./post-office-collect') ); diff --git a/apps/not-arrived/fields/post-office-collect.js b/apps/not-arrived/fields/post-office-collect.js new file mode 100644 index 00000000..10679772 --- /dev/null +++ b/apps/not-arrived/fields/post-office-collect.js @@ -0,0 +1,14 @@ +'use strict'; + +module.exports = { + 'post-office-collect-radio': { + isPageHeading: true, + mixin: 'radio-group', + className: ['govuk-radios--inline', 'form-group'], + options: [{ + value: 'yes' + }, { + value: 'no' + }] + } +}; diff --git a/apps/not-arrived/index.js b/apps/not-arrived/index.js index a2fadab4..2a17dd84 100644 --- a/apps/not-arrived/index.js +++ b/apps/not-arrived/index.js @@ -8,9 +8,9 @@ module.exports = { '/post-office-collect': { next: '/consignment-number', behaviours: [require('./behaviours/change-path')], - template: 'collection.html', + // template: 'collection.html', fields: [ - 'collection' + 'post-office-collect-radio' ] }, '/consignment-number': { diff --git a/apps/not-arrived/translations/src/en/fields.json b/apps/not-arrived/translations/src/en/fields.json index d62b66c9..3228debe 100644 --- a/apps/not-arrived/translations/src/en/fields.json +++ b/apps/not-arrived/translations/src/en/fields.json @@ -1,5 +1,6 @@ { - "collection": { + "post-office-collect-radio": { + "legend": "Were you due to collect your document from the Post Office?", "options": { "yes": { "label": "Yes" @@ -10,6 +11,7 @@ } }, "consignment-number-radio": { + "legend": "Do you have a consignment number?", "options": { "yes": { "label": "Yes" @@ -20,7 +22,6 @@ } }, "consignment-number": { - "legend": "Consignment number", "label": "What is your consignment number?" }, "delivery-date": { diff --git a/apps/not-arrived/translations/src/en/pages.json b/apps/not-arrived/translations/src/en/pages.json index c8d45bfa..ed62a5c9 100644 --- a/apps/not-arrived/translations/src/en/pages.json +++ b/apps/not-arrived/translations/src/en/pages.json @@ -1,7 +1,4 @@ { - "post-office-collect": { - "header": "Were you due to collect your document from the Post Office?" - }, "consignment-number": { "header": "Do you have a consignment number?" }, diff --git a/apps/not-arrived/views/confirm.html b/apps/not-arrived/views/confirm.html index 63c54028..656bbd3f 100644 --- a/apps/not-arrived/views/confirm.html +++ b/apps/not-arrived/views/confirm.html @@ -13,19 +13,8 @@ {{> partials-navigation}} {{/propositionHeader}} - {{$title}} - {{#t}}pages.check-details.header{{/t}} - {{/title}} - - {{$header}} - {{

{{#t}}pages.check-details-error.header{{/t}}

{{#t}}pages.check-details.subheader{{/t}}

{{ partials-navigation}} {{/propositionHeader}} - {{$title}} - {{#t}}pages.collection.header{{/t}} - {{/title}} - - {{$header}} - {{ partials-navigation}} {{/propositionHeader}} - {{$title}} - {{#t}}pages.arrange-collection.header{{/t}} - {{/title}} - - {{$header}} - {{

{{#t}}pages.arrange-collection.header{{/t}}

{{

{{#t}}pages.check-details.header{{/t}}

{{#t}}pages.someone-else-check-details.subheader{{/t}}

{{

{{#t}}journeys.someone-else.personal-details.header{{/t}}

{{#t}}journeys.someone-else.personal-details.subheader{{/t}}

{{