Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current settings disables all enforced status checks #142

Open
paddyroddy opened this issue Nov 6, 2023 · 0 comments
Open

Current settings disables all enforced status checks #142

paddyroddy opened this issue Nov 6, 2023 · 0 comments
Assignees
@paddyroddy
Labels
problem Something isn't working safe-settings Related to github/safe-settings deployment

Comments

@paddyroddy
Copy link
Member

paddyroddy commented Nov 6, 2023 •
edited by HChughtai
Loading

Short Description

Setting required_status_checks as null, means that you can't have any status checks 😢

Evidence/Steps to Reproduce

No response

Acceptance Criteria/Expected Behaviour

Either hosting our own (see UCL-MIRSG/admin#3) or awaiting an update on github/safe-settings#412.

Details

Follow github/safe-settings#412

Resolution

For repos where we really want enforced status checks can use rulesets. See https://github.com/UCL-MIRSG/UCLH-MPBE-SRR-XNAT for an example.
@HChughtai HChughtai changed the title 🔥 [INCIDENT]: Current settings disables all enforced status checks Current settings disables all enforced status checks Apr 21, 2024
@HChughtai HChughtai added the problem Something isn't working label Apr 21, 2024
@paddyroddy paddyroddy transferred this issue from UCL-MIRSG/admin Dec 16, 2024
@paddyroddy paddyroddy added the safe-settings Related to github/safe-settings deployment label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paddyroddy paddyroddy

Labels
problem Something isn't working safe-settings Related to github/safe-settings deployment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paddyroddy @HChughtai