Fixed #998 - Fixed a boolean logic error on line 646 of design.dart #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an error with the boolean logic on line 646 of `design.dart`. This was preventing the Chrome Dev Tools key shortcut from opening.
dave-doty
approved these changes
Oct 24, 2024
beanbeanjuice
deleted the
998-allow-ctrl+shift+i-to-open-developer-tools
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was an error with the boolean logic on line 646 of
design.dart. This was preventing the Chrome Dev Tools key shortcut from opening. Looking through the code, the dev tools opens on other browsers like Arc (F12) and Firefox (F12). I found out that the logic for detecting keyboard presses works properly inindex.htmlso I dug deeper through the code. It turns out thatdesign.dartwas firing when it should not have been, preventing the default behaviour ofCTRL + SHIFT + I.Related Issue
Fixes #998. This also fixes other issues where different hotkeys
CTRL + IorSHIFT + Iwould also toggle insertion mode.To reproduce the issue;
CTRL + SHIFT + I.For this fix, the above issue is prevented.
Motivation and Context
This fixes #998. This caused a bit of a headache when needing to open dev tools; causing us to use our mouse and press multiple buttons instead of
CTRL + SHIFT + I.How Has This Been Tested?
This was tested on Windows 11; on Chrome and Arc.