Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug with calculating helix rolls to minimize crossover strain #986

Open
dave-doty opened this issue Sep 10, 2024 · 2 comments
Open

fix bug with calculating helix rolls to minimize crossover strain #986

dave-doty opened this issue Sep 10, 2024 · 2 comments
Assignees
Labels
high priority Something cruicial to get working soon.

Comments

@dave-doty
Copy link
Member

Don't have time to describe in detail, but set up a simple system with two helices and the "unstrain crossovers" feature doesn't seem to get the angle correct. Not sure if it's also happening in the Python package. For reference, this design has the problem:

image

@dave-doty dave-doty added the high priority Something cruicial to get working soon. label Sep 10, 2024
@dave-doty dave-doty self-assigned this Sep 10, 2024
@dave-doty
Copy link
Member Author

I've got a bit more of a clue what's going on. Things look fine if there are no deletions/insertions. But there are deletions above, leading to the strange results. What I'm not sure about is whether

  1. The deletions are not being properly accounted for, or
  2. They are, and I'm just not thinking about how the assigned Helix roll angles are actually good, given the deletions.

@dave-doty dave-doty assigned beanbeanjuice and unassigned dave-doty Oct 25, 2024
@dave-doty
Copy link
Member Author

Here's the design above (mostly) with and without deletions: roll-issue-with-deletions.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Something cruicial to get working soon.
Projects
None yet
Development

No branches or pull requests

2 participants