Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PermissionsPolicy missing some permissions #29

Open
OscarVanL opened this issue Oct 22, 2024 · 2 comments
Open

PermissionsPolicy missing some permissions #29

OscarVanL opened this issue Oct 22, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@OscarVanL
Copy link

Hi,

I noticed the PermissionsPolicy doesn't have a few permissions like hid, identity-credentials-get, idle-detection, local-fonts, publickey-credentials-create, serial, storage-access, window-management.

Lots of these are experimental which might be why you've not included them, but other experimental permissions like xr_spacial_tracking() is included, so maybe this is just an omission rather than intentional.

@cak
Copy link
Member

cak commented Oct 22, 2024

Great catch! It was intentional not to include some of the experimental permissions, though a couple must have slipped in. I agree that adding these with clear docstrings noting their experimental status would be helpful. I’ll get this into the next release. Thanks again!

@cak cak added the enhancement New feature or request label Oct 22, 2024
@cak cak self-assigned this Oct 22, 2024
@OscarVanL
Copy link
Author

Thank you!

Part of me was thinking it could be more helpful to have an allowlist here rather than a blocklist.

My perspective is that I'd like to deny everything here unless I explicitly want that permission.

Really, this is a deficiency of the Permissions-Policy header (there should be a way to deny all except those allowed), but it would be cool if the package could help with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants