Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependencies to match quality checklist #4

Merged
merged 14 commits into from
Jun 26, 2020
Merged

Upgrade dependencies to match quality checklist #4

merged 14 commits into from
Jun 26, 2020

Conversation

rojasTob
Copy link
Contributor

Resolves #3

@po5i po5i changed the base branch from master to next May 11, 2020 15:15
@rojasTob rojasTob force-pushed the code-exchange-upgrade branch from d7c05ce to f439ebf Compare June 1, 2020 18:37
@rojasTob rojasTob force-pushed the code-exchange-upgrade branch from 52cb1ff to 32b70be Compare June 17, 2020 17:52
@rojasTob rojasTob force-pushed the code-exchange-upgrade branch from 058cd94 to 1725d14 Compare June 17, 2020 20:23
mmena1
mmena1 approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@mmena1 mmena1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. But then again, we might need to revisit this to setup webpack on the existing NodeJS application

@rojasTob rojasTob merged commit bf6de22 into next Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmena1 mmena1 mmena1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code Exchange quality checklist
2 participants
@rojasTob @mmena1