-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump DPPL version to 0.27 #2225
Conversation
Should |
Yep! Edited. |
But we need to merge TuringLang/DynamicPPL.jl#609 first |
Is the old syntax no longer supported, or just inefficient due to type instability? |
Old syntax is still supported for definition, but not for calling. |
Pull Request Test Coverage Report for Build 9130206833Details
💛 - Coveralls |
Anyone wants to give this the go-ahead? |
Waiting with the merge until I've gotten the other two PRs through, as they are not breaking (but need to fix tests) |
This includes a few breaking changes + some fixes.
Of greatest importance is:
prob"..."
macro is gone.@model demo(::Type{T}=...)
are now converted intodemo(::TypeWrap{T}=...)
to improve type-stability and thus performance. But this means that one can no longer calldemo(Vector{Float64})
but instead need to dodemo(TypeWrap{Vector{Float64}}())
.Close #2220