Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove graphinfo.jl #85

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Remove graphinfo.jl #85

merged 4 commits into from
Oct 25, 2023

Conversation

sunxd3
Copy link
Member

@sunxd3 sunxd3 commented Oct 24, 2023

Per #82

Project.toml Outdated
@@ -3,7 +3,7 @@ uuid = "7a57a42e-76ec-4ea3-a279-07e840d6d9cf"
keywords = ["probablistic programming"]
license = "MIT"
desc = "Common interfaces for probabilistic programming"
version = "0.6.3"
version = "0.6.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not breaking?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it should be. I thought that the code is not exported and few people were using it. But it is technically a interface change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not aware of anyone using this functionality, so it is fine either way.

@yebai yebai marked this pull request as ready for review October 25, 2023 14:16
Project.toml Outdated Show resolved Hide resolved
Co-authored-by: Tor Erlend Fjelde <[email protected]>
@sunxd3 sunxd3 closed this Oct 25, 2023
@sunxd3 sunxd3 reopened this Oct 25, 2023
@sunxd3
Copy link
Member Author

sunxd3 commented Oct 25, 2023

Close by mistakes

@yebai yebai merged commit 48f7182 into main Oct 25, 2023
@yebai yebai deleted the sunxd/remove_graphinfo branch October 25, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants