Custom favicons not working in 1.0 #8771
Comments
|
@david-cako the publication icon in the admin settings panel is what you're looking for - while the upload screen may look a bit large (all of the uploaders are the same), that's what you want to use to configure your publication icon. Going to close this as this isn't a bug in Ghost and was completely intentional. |
|
Just to make sure, I have to upload a 60x60px image for my favicon? |
|
I'm currently running into this and I'm 99% sure uploading a publication icon still doesn't override it :/ |
|
As of Ghost 1.0, I've added a section in the migration guide of the docs to cover this, and also opened an issue to add a check for this to GScan P.S. Also note favicons are EXTREMELY heavily cached by browsers. If you don't see it update please check it on a different device first. |
|
Okay, thank you both for clarifying. I will say, it's entirely non-obvious based on the admin panel. There doesn't seem to be any indication there or in the documentation that the Publication Icon is what you need to upload to display a custom favicon. |
|
I use custom storage, upload the favicon from admin settings and success. from the admin setting the url given for the favicon image is https://res.cloudinary.com/tendabiru/image/upload/q_auto:good/ywf2l3wagedtzlkvfdrr.png but when i open my-site/favicon.png it returns 500 with message
|
|
@aphe Could you please share the whole error message+stack? |
|
here's what i got from pm2 logs (ghost install using ghost-cli) |
|
@kirrg001 I'm using custom storage (Cloudinary), favicon shows correctly in admin under 'Publication Icon' ( <link rel="shortcut icon" href="/favicon.png" type="image/png">So no favicon is shown. What could the problem be?
|
|
Possibly related: #8885. |
|
@kirrg001 thank you for the info. |
|
@evenfrost You can always swing by our slack channel and ask in the |
This is expected - As @kirrg001 mentioned above, the
|
|
I pushed the method implementation suggested by @aphe which is fixing the problem. Actually pushed on the mmornati repo. I will push on the seth one too (I think we will keep only one repo). |
|
@mmornati can you confirm implementing |
|
@evenfrost have you save the changes (Save settings on the top right corner)? |
|
Yes, I've saved them. Favicon shows correctly in admin, but in blog it's still the same. Managed to overwrite it for now with setting explicit |
|
Edit: just saw the 'save settings' button and after using that everything is working as expected, I thought settings were saved as you edited. |
Issue Summary
Custom favicons are no longer working.
I've looked in the admin panel to make sure the favicon isn't configured there, but I don't see anything of the sort, only a way to upload a much larger "Publication Icon".
Two separate issues:
{{ asset "/favicon.ico" }}does not correctly source the theme favicon anymore. I would expect this to return/assets/favicon.ico, but it instead returns/favicon.ico.Further,
{{ ghost_head }}is adding another line of the default favicon to the page.I can't seem to override it, regardless of whether I put a hard-coded
<link rel="shortcut icon" href="/assets/favicon.ico" type="image/x-icon">before or after{{ ghost_head }}.Steps to Reproduce
Try to use
{{ asset "/favicon.ico" }}to serve a custom favicon from the theme assets.Technical details:
The text was updated successfully, but these errors were encountered: