Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md for adding fixes to avoid setup errors for Windows u… #483

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Srabasti
Copy link

…sers

Adding fixes to avoid setup errors for Windows users #372

…sers

Adding fixes to avoid setup errors for Windows users Trusted-AI#372

Signed-off-by: Srabasti Banerjee <[email protected]>
Copy link

@aviiciii aviiciii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@yehee yehee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just swinging by to give initial pass on the commit, I'll leave project owners to review :)

README.md Outdated
@@ -156,6 +156,21 @@ Then, navigate to the root directory of the project and run:
pip install --editable '.[all]'
```

###For Windows machine
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
###For Windows machine
### For Windows machine

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
@@ -156,6 +156,21 @@ Then, navigate to the root directory of the project and run:
pip install --editable '.[all]'
```

###For Windows machine

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Since this is conda installation instructions, lets add this to the conda section: https://github.com/Trusted-AI/AIF360#conda

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
mnagired and others added 2 commits September 27, 2023 12:33
Co-authored-by: Gowri Addepalli <[email protected]>
Signed-off-by: Manish Nagireddy <[email protected]>
Co-authored-by: Gowri Addepalli <[email protected]>
Co-authored-by: Alice <[email protected]>
Signed-off-by: Manish Nagireddy <[email protected]>
Copy link
Collaborator

@mnagired mnagired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for doing this!

Copy link
Author

@Srabasti Srabasti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants