-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md for adding fixes to avoid setup errors for Windows u… #483
base: main
Are you sure you want to change the base?
Conversation
…sers Adding fixes to avoid setup errors for Windows users Trusted-AI#372 Signed-off-by: Srabasti Banerjee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just swinging by to give initial pass on the commit, I'll leave project owners to review :)
README.md
Outdated
@@ -156,6 +156,21 @@ Then, navigate to the root directory of the project and run: | |||
pip install --editable '.[all]' | |||
``` | |||
|
|||
###For Windows machine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
###For Windows machine | |
### For Windows machine |
README.md
Outdated
@@ -156,6 +156,21 @@ Then, navigate to the root directory of the project and run: | |||
pip install --editable '.[all]' | |||
``` | |||
|
|||
###For Windows machine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Since this is conda installation instructions, lets add this to the conda section: https://github.com/Trusted-AI/AIF360#conda
Co-authored-by: Gowri Addepalli <[email protected]> Signed-off-by: Manish Nagireddy <[email protected]>
Co-authored-by: Gowri Addepalli <[email protected]> Co-authored-by: Alice <[email protected]> Signed-off-by: Manish Nagireddy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks for doing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestions!
…sers
Adding fixes to avoid setup errors for Windows users #372