Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality - Request Validation #40

Open
NirmalAgnihotri opened this issue May 8, 2023 · 0 comments
Open

Code Quality - Request Validation #40

NirmalAgnihotri opened this issue May 8, 2023 · 0 comments
Assignees

Comments

@NirmalAgnihotri
Copy link
Collaborator

NirmalAgnihotri commented May 8, 2023

Address high priority code item.
https://docs.google.com/document/d/1TzFotK3BFVGCeaOmzyQlfUUGDxo9iKZ0iqnPalUKQZ0/edit#

We will be using CakeType for validation:

https://github.com/justinyaodu/caketype

Testing:
Add functions to consumer.ts that call all the routes that use validation. Pass the wrong arguments to the routes and make sure you get back errors. For how to make these functions see https://github.com/TritonSE/SDCTA-Data-Visualization-Website/pull/37/files#diff-c80eed83e1555b783e52b0ca0a3b2066a5c8cb36ca1430d9705cb6c0e09c9901 for example of consumer.ts function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants